bug: dont send ready up unless were acutally waiting for ready system

Author: lukepolo

src/FiveStack.Events/PlayerConnected.cs

@@ -99,11 +99,14 @@ public HookResult OnPlayerJoinTeam(EventPlayerTeam @event, GameEventInfo info)
 
         CCSPlayerController player = @event.Userid;
 
-        _gameServer.Message(
-            HudDestination.Chat,
-            $" {ChatColors.Default}type {ChatColors.Green}{CommandUtility.PublicChatTrigger}r {ChatColors.Default}to be marked as ready for the match",
-            @event.Userid
-        );
+        if (_readySystem.IsWaitingForReady())
+        {
+            _gameServer.Message(
+                HudDestination.Chat,
+                $" {ChatColors.Default}type {ChatColors.Green}{CommandUtility.PublicChatTrigger}r {ChatColors.Default}to be marked as ready for the match",
+                @event.Userid
+            );
+        }
 
         _gameServer.Message(
             HudDestination.Chat,

src/FiveStack.Services/ReadySystem.cs

@@ -58,6 +58,11 @@ public void ResetReady()
         _readyPlayers.Clear();
     }
 
+    public bool IsWaitingForReady()
+    {
+        return _readyStatusTimer != null;
+    }
+
     public void ToggleReady(CCSPlayerController player)
     {
         if (player.UserId == null)

src/FiveStackPlugin.cs

@@ -13,13 +13,13 @@ public partial class FiveStackPlugin : BasePlugin
     private readonly GameDemos _gameDemos;
     private readonly GameServer _gameServer;
     private readonly MatchEvents _matchEvents;
+    private readonly ReadySystem _readySystem;
     private readonly TimeoutSystem _timeoutSystem;
     private readonly MatchService _matchService;
     private readonly SurrenderSystem _surrenderSystem;
     private readonly ILogger<FiveStackPlugin> _logger;
     private readonly GameBackUpRounds _gameBackupRounds;
     private readonly EnvironmentService _environmentService;
-
     public override string ModuleName => "FiveStack";
     public override string ModuleVersion => "__RELEASE_VERSION__";
     public override string ModuleAuthor => "5Stack.gg";
@@ -30,6 +30,7 @@ public FiveStackPlugin(
         GameServer gameServer,
         MatchEvents matchEvents,
         MatchService matchService,
+        ReadySystem readySystem,
         TimeoutSystem timeoutSystem,
         ILogger<FiveStackPlugin> logger,
         SurrenderSystem surrenderSystem,
@@ -41,6 +42,7 @@ EnvironmentService environmentService
         _gameDemos = matchDemos;
         _gameServer = gameServer;
         _matchEvents = matchEvents;
+        _readySystem = readySystem;
         _matchService = matchService;
         _timeoutSystem = timeoutSystem;
         _surrenderSystem = surrenderSystem;