🚨 fix clippy warnings

Author: AbdelStark

src/api/auth.rs

@@ -15,8 +15,10 @@ pub enum AuthError {
     /// Invalid token format
     InvalidTokenFormat,
     /// User not found
+    #[allow(dead_code)]
     UserNotFound,
     /// Storage error
+    #[allow(dead_code)]
     StorageError(StorageError),
 }
 
@@ -81,6 +83,7 @@ where
 }
 
 /// Authentication middleware to verify a user's token
+#[allow(dead_code)]
 pub async fn require_auth(
     State(state): State<crate::api::routes::AppState>,
     request: Request,

src/config/mod.rs

@@ -39,6 +39,7 @@ pub struct Config {
     /// LNBits invoice read key (if using LNBits)
     pub lnbits_invoice_read_key: Option<String>,
     /// LNBits webhook verification key (if using LNBits)
+    #[allow(dead_code)]
     pub lnbits_webhook_key: Option<String>,
     /// Whether Coinbase payments are enabled
     pub coinbase_enabled: bool,

src/payments/coinbase/mod.rs

@@ -87,22 +87,26 @@ struct ChargeData {
     /// Payment addresses for different cryptocurrencies
     addresses: HashMap<String, String>,
     /// Pricing information
+    #[allow(dead_code)]
     pricing: Option<PricingInfo>,
 }
 
 /// Pricing information from Coinbase response
 #[derive(Debug, Deserialize)]
 struct PricingInfo {
     /// Amount in local currency
+    #[allow(dead_code)]
     local: Option<LocalPrice>,
 }
 
 /// Local price information
 #[derive(Debug, Deserialize)]
 struct LocalPrice {
     /// Amount in local currency
+    #[allow(dead_code)]
     amount: String,
     /// Currency code
+    #[allow(dead_code)]
     currency: String,
 }
 

src/payments/lightning/mod.rs

@@ -11,13 +11,15 @@ use tracing::{debug, error, info};
 
 /// Errors that can occur when interacting with Lightning
 #[derive(Debug, Error)]
+#[allow(clippy::enum_variant_names)]
 pub enum LightningError {
     /// Network error
     #[error("Network error: {0}")]
     NetworkError(#[from] reqwest::Error),
 
     /// API error
     #[error("Lightning API error: {0}")]
+    #[allow(dead_code)]
     ApiError(String),
 
     /// Missing configuration
@@ -40,8 +42,10 @@ pub enum LightningError {
 /// Lightning payment provider using LNBits
 #[derive(Clone)]
 pub struct LightningProvider {
+    #[allow(dead_code)]
     http_client: HttpClient,
     lnbits_client: Option<LNBitsClient>,
+    #[allow(dead_code)]
     config: Arc<Config>,
 }
 
@@ -106,13 +110,9 @@ impl LightningProvider {
             LightningError::ConfigError("LNBits client not configured".to_string())
         })?;
 
-        info!("Invoice requested for {} USD", amount_usd);
-
         // Convert USD to satoshis using market rate
         let amount_sats = utils::convert_usd_to_sats(amount_usd).await?;
 
-        info!("Converted amount to {} sats", amount_sats);
-
         // Create invoice with 30 minute expiry (in seconds)
         let expiry = 30 * 60;
 
@@ -126,8 +126,6 @@ impl LightningProvider {
             out: false,
         };
 
-        info!("Invoice request: {:?}", invoice_request);
-
         // Create the invoice
         let invoice = client.create_invoice(&invoice_request).await?;
         Ok((invoice.bolt11, invoice.payment_hash))
@@ -155,7 +153,7 @@ impl LightningProvider {
 
         // Try to parse the webhook event
         let event: WebhookEvent =
-            serde_json::from_slice(body).map_err(|e| LightningError::SerializationError(e))?;
+            serde_json::from_slice(body).map_err(LightningError::SerializationError)?;
 
         debug!(
             "Parsed webhook event for payment_hash: {}",

src/payments/lnbits/mod.rs

@@ -1,4 +1,3 @@
-use chrono::{DateTime, Utc};
 use reqwest::{
     Client as HttpClient,
     header::{HeaderMap, HeaderValue},
@@ -41,53 +40,89 @@ pub struct CreateInvoiceRequest {
 
 #[derive(Debug, Deserialize)]
 pub struct CreateInvoiceResponse {
+    #[allow(dead_code)]
     pub checking_id: String,
     pub payment_hash: String,
+    #[allow(dead_code)]
     pub wallet_id: String,
+    #[allow(dead_code)]
     pub amount: u64,
+    #[allow(dead_code)]
     pub fee: u64,
     pub bolt11: String,
+    #[allow(dead_code)]
     pub status: String,
+    #[allow(dead_code)]
     pub memo: Option<String>,
+    #[allow(dead_code)]
     pub expiry: Option<String>,
+    #[allow(dead_code)]
     pub webhook: Option<String>,
+    #[allow(dead_code)]
     pub webhook_status: Option<u32>,
+    #[allow(dead_code)]
     pub preimage: Option<String>,
+    #[allow(dead_code)]
     pub tag: Option<String>,
+    #[allow(dead_code)]
     pub extension: Option<String>,
+    #[allow(dead_code)]
     pub time: String,
+    #[allow(dead_code)]
     pub created_at: String,
+    #[allow(dead_code)]
     pub updated_at: String,
+    #[allow(dead_code)]
     pub extra: serde_json::Value,
 }
 
 #[derive(Debug, Deserialize)]
 pub struct PaymentStatus {
     pub paid: bool,
     pub status: String,
+    #[allow(dead_code)]
     pub preimage: Option<String>,
+    #[allow(dead_code)]
     pub details: PaymentDetails,
 }
 
 #[derive(Debug, Deserialize)]
 pub struct PaymentDetails {
+    #[allow(dead_code)]
     pub checking_id: String,
+    #[allow(dead_code)]
     pub payment_hash: String,
+    #[allow(dead_code)]
     pub wallet_id: String,
+    #[allow(dead_code)]
     pub amount: u64,
+    #[allow(dead_code)]
     pub fee: u64,
+    #[allow(dead_code)]
     pub bolt11: String,
+    #[allow(dead_code)]
     pub status: String,
+    #[allow(dead_code)]
     pub memo: Option<String>,
+    #[allow(dead_code)]
     pub expiry: Option<String>,
+    #[allow(dead_code)]
     pub webhook: Option<String>,
+    #[allow(dead_code)]
     pub webhook_status: Option<u32>,
+    #[allow(dead_code)]
     pub preimage: Option<String>,
+    #[allow(dead_code)]
     pub tag: Option<String>,
+    #[allow(dead_code)]
     pub extension: Option<String>,
+    #[allow(dead_code)]
     pub time: String,
+    #[allow(dead_code)]
     pub created_at: String,
+    #[allow(dead_code)]
     pub updated_at: String,
+    #[allow(dead_code)]
     pub extra: serde_json::Value,
 }
 
@@ -101,7 +136,7 @@ impl LNBitsClient {
     ) -> Result<Self, LNBitsError> {
         let http_client = HttpClient::builder()
             .build()
-            .map_err(|e| LNBitsError::NetworkError(e))?;
+            .map_err(LNBitsError::NetworkError)?;
 
         Ok(Self {
             http_client,

src/payments/mod.rs

@@ -15,8 +15,7 @@ use std::sync::Arc;
 use thiserror::Error;
 use tracing::{debug, error, info};
 
-// Re-export LNBits types
-pub use lnbits::{LNBitsClient, LNBitsError};
+// No exports needed
 
 /// Errors that can occur in payment processing
 #[derive(Debug, Error)]
@@ -43,10 +42,12 @@ pub enum PaymentError {
 
     /// User not found
     #[error("User not found: {0}")]
+    #[allow(dead_code)]
     UserNotFound(String),
 
     /// Invalid input
     #[error("Invalid input: {0}")]
+    #[allow(dead_code)]
     InvalidInput(String),
 }
 

src/services/block_service.rs

@@ -6,6 +6,7 @@ use tracing::{error, info};
 
 /// Errors that can occur when fetching block data
 #[derive(Debug, Error)]
+#[allow(clippy::enum_variant_names)]
 pub enum BlockDataError {
     /// Network error
     #[error("Network error: {0}")]

src/utils/mod.rs

@@ -7,6 +7,7 @@ use thiserror::Error;
 use tracing::{debug, error};
 
 #[derive(Debug, Error)]
+#[allow(clippy::enum_variant_names)]
 pub enum ConversionError {
     #[error("Network error: {0}")]
     NetworkError(#[from] reqwest::Error),