correctly raise error for OPM request

stefdoerr · stefdoerr · commit 6c67c6099488 · 2025-11-20T15:40:23.000+02:00
diff --git a/moleculekit/opm.py b/moleculekit/opm.py
@@ -142,6 +142,7 @@ def get_opm_pdb(pdbid, keep=False, keepaltloc="A", validateElements=False):
         resp = requests.get(
             f"https://storage.googleapis.com/opm-assets/pdb/{pdbid.lower()}.pdb"
         )
+        resp.raise_for_status()
     except Exception as e:
         raise RuntimeError(f"Failed to fetch OPM with PDB ID {pdbid} with error {e}")
 

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,7 @@ def get_opm_pdb(pdbid, keep=False, keepaltloc="A", validateElements=False):`
`142`	`142`	`resp = requests.get(`
`143`	`143`	`f"https://storage.googleapis.com/opm-assets/pdb/{pdbid.lower()}.pdb"`
`144`	`144`	`)`
	`145`	`+ resp.raise_for_status()`
`145`	`146`	`except Exception as e:`
`146`	`147`	`raise RuntimeError(f"Failed to fetch OPM with PDB ID {pdbid} with error {e}")`
`147`	`148`