Merge pull request #29 from AdaInTheLab/fix/note-card-link

SCMS [SCMS] Make Lab Note cards locale-aware and link to detail view 🔗

Author: AdaInTheLab

src/components/labnotes/LabNoteCard.tsx

@@ -30,6 +30,7 @@
 // src/components/labnotes/LabNoteCard.tsx
 import React from "react";
 import { Link } from "react-router-dom";
+const { i18n } = useTranslation("labNotesPage");
 import { useTranslation } from "react-i18next";
 import type { LabNote } from "@/lib/labNotes";
 
@@ -83,6 +84,7 @@ type Props = {
 };
 
 export function LabNoteCard({ note, index }: Props) {
+    const locale = i18n.language || "en";
     const { t } = useTranslation("labNotesPage");
     // Prefer canonical department_id; dept is optional label
     const deptKey = (note.dept ?? note.department_id ?? "scms").toLowerCase();
@@ -236,7 +238,7 @@ export function LabNoteCard({ note, index }: Props) {
         </span>
 
                 <Link
-                    to={`/lab-notes/${note.slug}`}
+                    to={`/${locale}/lab-notes/${note.slug}`}
                     className={`text-xs font-bold uppercase tracking-widest transition-all ${styles.text} hover:tracking-[0.2em]`}
                 >
                     {t("readMore", { defaultValue: "Open Note" })} →

src/pages/LabNoteDetailPage.tsx

@@ -32,19 +32,21 @@ import { fetchLabNoteBySlug, getLabNotes } from "@/lib/labNotes";
 import type { LabNote } from "@/lib/labNotes";
 
 type RouteParams = {
-    id?: string; // slug-style id
+    slug?: string;
+    locale?: string; // if you add :locale routes
 };
 
 export function LabNoteDetailPage() {
-    const { id } = useParams<RouteParams>();
+    const { slug, locale: routeLocale } = useParams<RouteParams>();
     const { i18n, t } = useTranslation("labNotesPage");
-    const locale = i18n.language || "en";
+    const locale = routeLocale || i18n.language || "en";
+    const base = `/${locale}`;
 
     const [note, setNote] = useState<LabNote | null>(null);
     const [loading, setLoading] = useState(true);
 
     useEffect(() => {
-        if (!id) return;
+        if (!slug) return;
 
         const controller = new AbortController();
         let alive = true;
@@ -53,7 +55,7 @@ export function LabNoteDetailPage() {
             setLoading(true);
 
             try {
-                const data = await fetchLabNoteBySlug(locale, id, controller.signal);
+                const data = await fetchLabNoteBySlug(locale, slug, controller.signal);
 
                 if (!alive) return;
                 setNote(data);
@@ -71,7 +73,7 @@ export function LabNoteDetailPage() {
                 console.error(e);
 
                 // Local fallback (useful when API is down)
-                const local = getLabNotes(locale).find((n) => n.id === id) ?? null;
+                const local = getLabNotes(locale).find((n) => n.id === slug) ?? null;
                 setNote(local);
             } finally {
                 if (alive) setLoading(false);
@@ -83,7 +85,7 @@ export function LabNoteDetailPage() {
             alive = false;
             controller.abort();
         };
-    }, [id, locale]);
+    }, [slug, locale]);
 
     if (loading) {
         return (
@@ -108,7 +110,7 @@ export function LabNoteDetailPage() {
                         This entry has been retracted or never existed in this timeline.
                     </p>
                     <Link
-                        to="/lab-notes"
+                        to={`${base}/lab-notes`}
                         className="mt-8 text-lyric hover:text-ada transition-colors"
                     >
                         ← Return to Registry
@@ -127,7 +129,7 @@ export function LabNoteDetailPage() {
                 {/* Breadcrumb */}
                 <nav className="mb-8 flex items-center justify-between">
                     <Link
-                        to="/lab-notes"
+                        to={`${base}/lab-notes`}
                         className="group inline-flex items-center gap-2 rounded-full
                border border-slate-800 bg-slate-950/40 px-4 py-2
                text-xs font-mono uppercase tracking-[0.2em] text-slate-400

src/router/routes.tsx

@@ -91,9 +91,13 @@ export const router = createBrowserRouter([
             // Future-friendly dynamic detail route (if/when needed)
             { path: "departments/:id", element: (<Suspense fallback={<PageLoader />}><DepartmentDetailPage /></Suspense> ) },
 
+            // List
             { path: "lab-notes", element: (<Suspense fallback={<PageLoader />}><LabNotesPage /> </Suspense> )},
-            { path: "lab-notes/:id", element: <LabNoteDetailPage /> },
+            { path: ":locale/lab-notes", element: (<Suspense fallback={<PageLoader />}><LabNotesPage /> </Suspense> )},
+
+            // Detail (pick ONE param name; use slug)
             { path: "lab-notes/:slug", element: <LabNoteDetailPage /> },
+            { path: ":locale/lab-notes/:slug", element: <LabNoteDetailPage /> },
 
             { path: "videos", element: (<Suspense fallback={<PageLoader />}><VideoArchivePage /></Suspense> ) },
             { path: "videos/:slug", element: <VideoDetailPage /> },