Improve 'listteams' command

- Add default aliases
- Add HTML response

Author: AgustinSRG

src/bot-modules/battle/commands-teams.js

@@ -209,13 +209,13 @@ module.exports = {
 		this.reply(this.mlt(15) + ' ' + App.server.getControlPanelLink('/temp/' + key));
 	},
 
+	teams: "listteams",
+	getteams: "listteams",
 	listteams: function (App) {
 		this.setLangFile(Lang_File);
 
 		if (!this.can('teams', this.room)) return this.replyAccessDenied('teams');
 
-		const canCode = this.getRoomType(this.room) === 'chat' && botCanUseCode(this.room, App);
-
 		const mod = App.modules.battle.system;
 
 		const Teams = mod.TeamBuilder.tools;
@@ -251,13 +251,35 @@ module.exports = {
 			return "  - " + t.name + ": " + Teams.teamOverview(t.packed);
 		}).join("\n");
 
-		if (canCode) {
-			this.replyCommand(code);
-		} else {
-			this.pmReply(code);
-		}
+		let html = '';
+
+		html += '<div style="overflow: auto; max-height: 300px; width: 100%;">';
+
+		html += '<p>' + Text.escapeHTML(this.mlt(14)) + " " + Text.escapeHTML(formatName) + ':</p>';
+
+		html += '<table border="1" cellspacing="0" cellpadding="3" style="min-width:100%;">';
+
+		html += '<tr>';
+		html += '<th>' + Text.escapeHTML(this.mlt("teamname")) + '</th>';
+		html += '<th>' + Text.escapeHTML(this.mlt("pokemon")) + '</th>';
+		html += '</tr>';
+
+		teams.forEach(t => {
+			const exportedTeam = Teams.exportTeam(t.packed);
+			html += '<tr>';
+			html += '<td><b>' + Text.escapeHTML(t.name) + '</b></td>';
+			html += '<td><details><summary>' + Teams.teamOverviewShowdownHTML(t.packed) + '</summary><pre>' + Text.escapeHTML(exportedTeam) + '</pre></details></td>';
+			html += '</tr>';
+		});
+
+		html += '</table>';
+
+		html += '</div>';
+
+		this.htmlRestrictReply(html, "teams", code);
 	},
 
+	team: "getteam",
 	getteam: function (App) {
 		this.setLangFile(Lang_File);
 

src/bot-modules/battle/commands-teams.translations

@@ -34,6 +34,9 @@ $15 = Teams available for the bot:
 
 $16 = No available teams for format:
 
+$teamname = Team Name
+$pokemon = Pokemon
+
 %spanish
 
 $0 = Nombre del equipo
@@ -60,8 +63,11 @@ $12 = Equipo eliminado:
 
 $13 = No poseo equipos para jugar en ningún formato.
 
-$14 = Equipos para el formato:
+$14 = Equipos disponibles para el formato:
 
 $15 = Equipos disponibles del bot:
 
 $16 = No poseo equipos para jugar en el formato:
+
+$teamname = Nombre del equipo
+$pokemon = Pokemon

src/bot-modules/battle/sprites.js

@@ -497,6 +497,11 @@ function getPiconSpan(num) {
 	return `<span class="picon" style="background:transparent url(${POKE_SPRITES_URL}sprites/pokemonicons-sheet.png?v19) no-repeat scroll -${left}px -${top}px"></span>`;
 }
 
+function getPsPokeIcon(name) {
+	name = Text.toId(name);
+	return '<psicon pokemon="' + Text.escapeHTML(name) + '"/> ';
+}
+
 exports.getPokemonIconAndName = function (poke, App) {
 	poke = Text.toId(poke);
 
@@ -524,3 +529,23 @@ exports.getPokemonIconAndName = function (poke, App) {
 
 	return getPiconSpan(num) + "&nbsp;" + Text.escapeHTML(name);
 };
+
+exports.getPokemonIconAndNameForShowdown = function (poke, App) {
+	poke = Text.toId(poke);
+
+	let pokedex;
+	try {
+		pokedex = App.data.getPokedex();
+	} catch (err) {
+		App.reportCrash(err);
+		return getPsPokeIcon('notfound') + "&nbsp;" + poke;
+	}
+
+	if (!pokedex[poke]) {
+		return getPsPokeIcon('notfound') + "&nbsp;" + poke;
+	}
+
+	let name = pokedex[poke].species || pokedex[poke].name || poke;
+
+	return getPsPokeIcon(poke) + "&nbsp;" + Text.escapeHTML(name);
+};

src/bot-modules/battle/teams.js

@@ -423,6 +423,22 @@ exports.setup = function (App) {
 		return pokes.join(', ');
 	};
 
+	/**
+	 * Gets team HTML overview (pokemon names and icons)
+	 * @param {String} buf - Packed team
+	 * @returns {String} List of pokemon
+	 */
+	TeamsTools.teamOverviewShowdownHTML = function (buf) {
+		let team = fastUnpackTeam(buf);
+		if (!team) return '(empty)';
+		let pokes = [];
+		for (let i = 0; i < team.length; i++) {
+			pokes.push(SpriteTools.getPokemonIconAndNameForShowdown(team[i].species, App));
+		}
+		if (!pokes.length) return '(empty)';
+		return pokes.join(', ');
+	};
+
 	/**
 	 * Transforms a JSON team to exportable format
 	 * @param {Object} team - JSON team