Skip to content

Commit 712db08

Browse files
committed
Update i18n to be accurate when choosing languages
1 parent dd412f1 commit 712db08

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

build.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ async function cleanUp() {
1313
console.log("🧹 Cleaning up build files...")
1414
const foldersDelete = ["out", "dist"]
1515
foldersDelete.forEach(folder => {
16-
fs.rmdir(path.join(__dirname, folder), { recursive: true }, (err) => {
16+
fs.rm(path.join(__dirname, folder), { recursive: true, force: true }, (err) => {
1717
if (err) {
1818
// Ignore errors
1919
}

src/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ <h2 class="no-margin text-center">Demo settings</h2>
6969
<label class="default">
7070
Change language
7171
<select id="language">
72-
<option value="">Default: Local language</option>
72+
<option value="">Default: English (United Kingdom)</option>
7373
</select>
7474
</label>
7575
<label class="default">

src/js/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ if (isExtension) {
217217
})
218218

219219
// Load all languages
220-
for (const [k, v] of Object.entries(availableLanguages())) {
220+
for (const [k, v] of Object.entries(availableLanguages({ hideDefault: true }))) {
221221
const option = document.createElement("option")
222222
option.text = v
223223
option.value = k

src/js/options.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ function restoreOptions() {
184184

185185
document.addEventListener("DOMContentLoaded", () => {
186186
const languages = document.getElementById("language")
187-
for (const [k, v] of Object.entries(availableLanguages())) {
187+
for (const [k, v] of Object.entries(availableLanguages({hideDefault: true}))) {
188188
const option = document.createElement("option")
189189
option.text = v
190190
option.value = k

src/js/utils/i18n.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,13 @@ export function translate(lang, key, args = {}) {
5050

5151
/**
5252
* Get a list of available languages with their native names
53+
* @param {boolean} hideDefault - Whether to hide the default language from the list
5354
* @returns {Object} Object with language codes as keys and native names as values
5455
*/
55-
export function availableLanguages() {
56+
export function availableLanguages({ hideDefault = false } = {}) {
5657
const langs = {}
5758
for (const code in translations) {
59+
if (hideDefault && code === DEFAULT_LANG) continue
5860
langs[code] = translations[code]["language.name"] || code
5961
}
6062
return langs

src/js/utils/weather.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { http } from "./http.js"
2-
import { translate, availableLanguages } from "./i18n.js"
2+
import { translate } from "./i18n.js"
33
import { reverseGeocode } from "./openstreetmap.js"
44
import { Cache } from "./cache.js"
55

@@ -65,5 +65,3 @@ export async function getWeather(items, position, lang) {
6565
cache.set(cacheKey, wname.innerText)
6666
})
6767
}
68-
69-
export const languages = availableLanguages()

src/options.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ <h1 class="no-margin">General settings</h1>
1919
<label class="column secondary-bg">
2020
Language:
2121
<select id="language">
22-
<option value="">Default: Local language</option>
22+
<option value="">Default: English (United Kingdom)</option>
2323
</select>
2424
</label>
2525
<label><input type="checkbox" id="show-settings"> Show settings button</label>

0 commit comments

Comments
 (0)