Skip to content

Commit 3c81f00

Browse files
committed
fix: only sign bundles if a key is provided
1 parent 4a953c5 commit 3c81f00

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

appimagebuilder/modules/prime/type_3.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def __init__(self, app_dir, cache_dir="appimage-builder-cache"):
3434
self.required_tool_paths = shell.resolve_commands_paths(["mksquashfs", "gpg"])
3535

3636
def create(
37-
self, output_filename, metadata=None, gnupg_key=None, compression_method="gzip"
37+
self, output_filename, metadata=None, gnupg_key=None, compression_method="gzip"
3838
):
3939
if metadata is None:
4040
metadata = {}
@@ -57,7 +57,9 @@ def create(
5757
output_filename, payload_offset, metadata_offset, signatures_offset
5858
)
5959

60-
self._sign_bundle(output_filename, gnupg_key, signatures_offset)
60+
if gnupg_key:
61+
self._sign_bundle(output_filename, gnupg_key, signatures_offset)
62+
6163
# remove squashfs
6264
squashfs_path.unlink()
6365

@@ -89,7 +91,7 @@ def _resolve_executable(self):
8991
return path
9092

9193
def _fill_header(
92-
self, output_filename, payload_offset, metadata_offset, signature_offset
94+
self, output_filename, payload_offset, metadata_offset, signature_offset
9395
):
9496
with open(output_filename, "r+b") as f:
9597
f.seek(0x410, 0)
@@ -105,8 +107,8 @@ def _get_runtime_path(self, arch):
105107

106108
def _get_runtime_url(self, arch):
107109
runtime_url_template = (
108-
self.runtime_project_url
109-
+ "/releases/download/continuous/runtime-Release-%s"
110+
self.runtime_project_url
111+
+ "/releases/download/continuous/runtime-Release-%s"
110112
)
111113
runtime_url = runtime_url_template % arch
112114
return runtime_url

0 commit comments

Comments
 (0)