Skip to content

fix: join_server links cause flutter error when launcher is opened through link #33

@AdamRaichu

Description

@AdamRaichu

Description

You can copy links to open the join modal for servers. e.g. https://api.prod.kyber.gg/redirect?target=join_server%3Fserver_id%3Df727fdfa8da78128a3b8c283a44c6b21 (an official server at time of writing). This link redirects to a custom url scheme that opens the join modal. If the launcher is not open, it will attempt to open it. However, the modal expects mods to be loaded. If the launcher is opened through the deep link, mods have not finished loading yet. This puts the launcher into the white box error.

Steps To Reproduce

  1. Copy a join link for any server on the list.
  2. Close the kyber launcher.
  3. Open the join link in your browser.
  4. Observer the launcher opening and the screen going white.

Expected Behavior

The launcher should wait for mods to finish loading before attempting to show the join modal.

Screenshots

Image

Additional Context

Note that the error screen can be closed by pressing ESC.

In general I am finding the join link feature inconsistent in my testing right now, sometimes it doesn't appear to do anything at all.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions