Skip to content

Commit 08bd941

Browse files
authored
Re-enable SpringMonitorTest for Spring 7 (#47928)
1 parent 1181e08 commit 08bd941

File tree

3 files changed

+18
-9
lines changed

3 files changed

+18
-9
lines changed

sdk/spring/spring-cloud-azure-starter-monitor-test/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,12 @@
6767
<version>4.0.2</version> <!-- {x-version-update;springboot4_org.springframework.boot:spring-boot-resttestclient;external_dependency} -->
6868
<scope>test</scope>
6969
</dependency>
70+
<dependency>
71+
<groupId>org.springframework.boot</groupId>
72+
<artifactId>spring-boot-restclient</artifactId>
73+
<version>4.0.2</version> <!-- {x-version-update;springboot4_org.springframework.boot:spring-boot-restclient;external_dependency} -->
74+
<scope>test</scope>
75+
</dependency>
7076
<dependency>
7177
<groupId>com.azure</groupId>
7278
<artifactId>azure-core-test</artifactId>

sdk/spring/spring-cloud-azure-starter-monitor-test/src/test/java/com/azure/spring/cloud/autoconfigure/monitor/CustomValidationPolicy.java

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import com.azure.core.http.HttpPipelineNextPolicy;
77
import com.azure.core.http.HttpResponse;
88
import com.azure.core.http.policy.HttpPipelinePolicy;
9+
import com.azure.core.test.http.MockHttpResponse;
910
import com.azure.core.util.FluxUtil;
1011
import com.azure.json.JsonProviders;
1112
import com.azure.json.JsonReader;
@@ -33,14 +34,17 @@ final class CustomValidationPolicy implements HttpPipelinePolicy {
3334

3435
@Override
3536
public Mono<HttpResponse> process(HttpPipelineCallContext context, HttpPipelineNextPolicy next) {
36-
url = context.getHttpRequest().getUrl();
37-
Mono<byte[]> asyncBytes = FluxUtil.collectBytesInByteBufferStream(context.getHttpRequest().getBody())
38-
.map(LocalStorageTelemetryPipelineListener::ungzip);
39-
asyncBytes.subscribe(value -> {
40-
actualTelemetryItems.addAll(deserialize(value));
41-
countDown.countDown();
42-
});
43-
return next.process();
37+
URL requestUrl = context.getHttpRequest().getUrl();
38+
if (requestUrl.getPath().contains("/v2.1/track")) {
39+
url = requestUrl;
40+
Mono<byte[]> asyncBytes = FluxUtil.collectBytesInByteBufferStream(context.getHttpRequest().getBody())
41+
.map(LocalStorageTelemetryPipelineListener::ungzip);
42+
asyncBytes.subscribe(value -> {
43+
actualTelemetryItems.addAll(deserialize(value));
44+
countDown.countDown();
45+
});
46+
}
47+
return Mono.just(new MockHttpResponse(context.getHttpRequest(), 200));
4448
}
4549

4650
// Copied from com.azure.monitor.opentelemetry.exporter.implementation.utils.TestUtils.java

sdk/spring/spring-cloud-azure-starter-monitor-test/src/test/java/com/azure/spring/cloud/autoconfigure/monitor/SpringMonitorTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838
classes = {Application.class, SpringMonitorTest.TestConfig.class},
3939
webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT)
4040
@AutoConfigureTestRestTemplate
41-
@Disabled("Needs to be fixed for Spring 7")
4241
class SpringMonitorTest {
4342

4443
private static CountDownLatch countDownLatch;

0 commit comments

Comments
 (0)