-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
bugA problem that needs to be fixed for the feature to function as intended.A problem that needs to be fixed for the feature to function as intended.msal-nodeRelated to msal-node packageRelated to msal-node packagepublic-clientIssues regarding PublicClientApplicationsIssues regarding PublicClientApplications
Description
Core Library
MSAL Node (@azure/msal-node)
Core Library Version
5.0.2
Wrapper Library
Not Applicable
Wrapper Library Version
None
Public or Confidential Client?
Public
Description
The comment annotations for INetworkModule don't match the method signatures -- there's reference to a "enableCaching" parameter that isn't present and timeout is included as a parameter for setGetRequestAsync but not referenced in the comments.
Error Message
No response
MSAL Logs
No response
Network Trace (Preferrably Fiddler)
- Sent
- Pending
MSAL Configuration
{
}Relevant Code Snippets
`
export interface INetworkModule {
/**
* Interface function for async network "GET" requests. Based on the Fetch standard: https://fetch.spec.whatwg.org/
* @param url
* @param requestParams
* @param enableCaching
*/
sendGetRequestAsync<T>(
url: string,
options?: NetworkRequestOptions,
timeout?: number
): Promise<NetworkResponse<T>>;
/**
* Interface function for async network "POST" requests. Based on the Fetch standard: https://fetch.spec.whatwg.org/
* @param url
* @param requestParams
* @param enableCaching
*/
sendPostRequestAsync<T>(
url: string,
options?: NetworkRequestOptions
): Promise<NetworkResponse<T>>;
}
`Reproduction Steps
Look at code
Expected Behavior
Comments / annotations match method signatures
Identity Provider
Entra ID (formerly Azure AD) / MSA
Browsers Affected (Select all that apply)
None (Server)
Regression
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugA problem that needs to be fixed for the feature to function as intended.A problem that needs to be fixed for the feature to function as intended.msal-nodeRelated to msal-node packageRelated to msal-node packagepublic-clientIssues regarding PublicClientApplicationsIssues regarding PublicClientApplications