Skip to content

PlatformService.executeIfSupportedAsync - HandshakeException crash #4531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaravgarg wants to merge 1 commit into from
+5 −1
Closed

PlatformService.executeIfSupportedAsync - HandshakeException crash #4531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/lib/utils/platform/platform_service.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,11 @@ class PlatformService {
/// Execute a future function only if the platform supports it
static Future<T?> executeIfSupportedAsync<T>(bool isSupported, Future<T> Function() function, {T? fallback}) async {
if (isSupported) {
return await function();
try {
return await function();
} on HandshakeException {
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While catching HandshakeException fixes the specific crash reported, it would be more robust to catch the more general IOException. This would handle other network-related errors as well, such as SocketException (e.g., no internet connection) or other I/O errors, which seems to align with the goal of gracefully handling "network issues" as mentioned in the test plan. HandshakeException itself is a subtype of IOException.

Suggested change
} on HandshakeException {
} on IOException {

return fallback;
}
}
return fallback;
}
Expand Down