Merge pull request #30 from Bee-Lab/deprecation

🗑️ deprecate assertSelectorCounts

Author: garak

.github/workflows/build.yaml

@@ -10,7 +10,7 @@ jobs:
         name: PHPStan
         steps:
             - name: Checkout
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
             - name: PHPStan
               uses: docker://oskarstark/phpstan-ga
               env:
@@ -22,9 +22,11 @@ jobs:
         name: PHP-CS-Fixer
         steps:
             - name: Checkout
-              uses: actions/checkout@v3
+              uses: actions/checkout@v4
             - name: Fix CS
               uses: docker://oskarstark/php-cs-fixer-ga
+              with:
+                args: --diff --dry-run
     tests:
         runs-on: ubuntu-24.04
         strategy:

src/Test/WebTestCase.php

@@ -249,7 +249,9 @@ protected static function submitFormByData(
 
     protected static function assertSelectorCounts(int $number, string $selector, string $message = ''): void
     {
-        self::assertCount($number, self::$client->getCrawler()->filter($selector), $message);
+        @\trigger_error(\sprintf('%s is deprecated since version %s, use self::assertSelectorCount instead.', __METHOD__, '7.1'), \E_USER_DEPRECATED);
+
+        self::assertSelectorCount($number, $selector, $message);
     }
 
     protected static function tickCheckboxes(Form $form, array $checkboxValues = []): void

tests/Test/WebTestCaseTest.php

@@ -74,7 +74,7 @@ function (string $parameter): string {
         $method = new \ReflectionMethod(self::$mock, 'saveOutput');
         $method->invoke(self::$mock, false);
 
-        /** @var \org\bovigo\vfs\vfsStreamFile $file */
+        /** @var \org\bovigo\vfs\vfsStreamFile|null $file */
         $file = $vfs->getChild('public/test.html');
         self::assertNotNull($file);
         self::assertEquals('Response content', $file->getContent());