Merge pull request #261 from Bijikyu/q/update-saferesolve-to-handle-nonexistent-paths

Improve safeResolve error handling

Author: Bijikyu

index.js

@@ -30,6 +30,10 @@ let errLog; // holds qerrors function or console fallback
 try { // attempts qerrors for structured logging like logger utility
   errLog = require('qerrors'); // assigns qerrors when available for consistency
 } catch { errLog = null; } // absence handled later to preserve console output
+let fs; // holds node:fs module for existence checks
+if(typeof require==='function'){ // ensures require exists before attempting fs load
+  try { fs = require('node:fs'); } catch { fs = null; } // safe attempt to load fs or fallback
+} else { fs = null; } // browser environment fallback when require undefined
 
 /*
  * MAIN EXPORT OBJECT CONSTRUCTION
@@ -53,6 +57,11 @@ function safeResolve(file){ // resolves path when require is present or falls ba
  } // logs unexpected errors
  const baseDir = typeof __dirname === 'string' ? __dirname : ''; // guards __dirname so browsers without Node globals do not throw
  const abs = path.resolve(baseDir, file); // absolute fallback ensures bundlers find correct file even without require
+ if(fs && fs.existsSync && !fs.existsSync(abs)){ // verifies file exists when using fallback
+  const err = new Error(`file not found: ${abs}`); // error describes missing file path
+  if(errLog){ errLog(err,'safeResolve missing',{file}); } else { console.error('safeResolve missing:', err.message); } // logs via qerrors or console
+  throw err; // throws to signal unresolved path to caller
+ }
  console.log(`safeResolve is returning ${abs}`); // logs absolute fallback path
  return abs; // returns absolute path when require unavailable for browser bundling
 }

test/index.safeResolve-error.test.js

@@ -0,0 +1,20 @@
+require('./helper');
+const assert = require('node:assert');
+const fs = require('node:fs');
+const path = require('node:path');
+const os = require('node:os');
+const vm = require('node:vm');
+const {describe, it} = require('node:test');
+
+describe('safeResolve missing file', {concurrency:false}, () => {
+  it('throws when fallback path does not exist', () => {
+    const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'sr-')); // temp dir for sandbox
+    const code = fs.readFileSync(path.resolve(__dirname, '../index.js'), 'utf8'); // module source
+    const nodeRequire = require; // capture native require
+    function req(id){ return nodeRequire(id); } // passthrough require
+    req.resolve = undefined; // remove resolve to trigger fallback branch
+    const sandbox = {require:req,module:{exports:{}},exports:{},console,__dirname:tmp,__filename:path.join(tmp,'index.js')};
+    assert.throws(() => vm.runInNewContext(code, sandbox, {filename:'index.js'})); // expect error on missing file
+    fs.rmSync(tmp,{recursive:true,force:true}); // cleanup temp directory
+  });
+});