[Potential Bug] Re-emitting old messages a new-message events #765
Description
i think i potentially see a bug with sending new-message notifications multiple times:
- We have a cache that gets maintained that tracks "emitted" events.
- The cache gets pruned every so often, removing things that have been in the cache for > 1 hour
- When we poll the database, we look back 1 weeks time, and rely on the cache to prevent duplicates from being emitted
- Since the cache gets pruned, it allows events to be re-emitted
It's 100% weird though that people are not reporting duplicate notifications (on the Android side). I would think that they would report it if the bug was as severe as it seems to be. So maybe there is something else at play.
I know that the android app tracks GUIDs for notified messages, however, this is mainly just an in-memory cache and would not persist when the app fully closes, which probably happens daily. So this bug should show itself. But it doesn't seem to.
Dupe emit bug seems to happen on macOS Sequoia. Likely happens on other versions as well.