-
Notifications
You must be signed in to change notification settings - Fork 2
Description
-
The start of any outsider into your Github Repo is your ReadME file and y'all have done a great job in that regard. The File is very well organized and has detailed description on how to access this repository . This also would help others who would like to contribute to this project.
-
Coming to The UI i.e. the Webpage, http://medusapys.site/index.html , it is very nicely made. It is user friendly and very accessible . The only issue I had with it, was that when I tried uploading a file to run your application, I get sent to a DeadEnd where I receive a confirmation that my file is uploaded. It would be more useful, if that can redirect me to a page into the Website.
-
The python files written by y'all seem to be very well maintained. There are comments when required and there is a good use of variable names which makes it easier for outsiders like me to understand your code. The only suggestion I would give is that y'all should run the codes through PEP8 or PYLINT which could make the code look more presentable although that need not be a priority, considering the amount of work to be done.
-
I do not see a license in the Master Branch of your code. Maybe its a good idea to do so.
-
The Achieve folder seems some what a mystery to me. There was no Read ME file as well as there were many formats of files, which got me very confused.
-
MAJOR PROBLEM: In your database directory, I can see your Database credentials, which is not a good idea at all. I Can go at this second and make malicious changes in your DB. Please look into this ASAP.
-
As we heard Prof. Osama say, try avoiding arbitrary numbers in the code, since it may differ from architecture to architecture.
Finally I would like to say, that y'all have done a good job and keep it up!!