fix not actually using variants

Author: jordan-evens

.github/workflows/cmake-test.yml

@@ -8,7 +8,7 @@ on:
 
 jobs:
   job:
-    name:  ${{ matrix.os }}-${{ matrix.os_version }}-${{ matrix.compiler }}-${{ matrix.build_type }}
+    name: ${{ matrix.os }}-${{ matrix.os_version }}-${{ matrix.compiler }}-${{ matrix.variant }}
     runs-on: ${{ matrix.os }}-${{ matrix.os_version }}
 
     strategy:
@@ -17,7 +17,7 @@ jobs:
         os: [macos, ubuntu, windows]
         os_version: [latest]
         compiler: [cl, clang++, g++]
-        build_type: [debug, release]
+        variant: [Debug, Release]
         include:
           - os: macos
             compiler: clang++
@@ -45,7 +45,6 @@ jobs:
 
     env:
       CXX: ${{ matrix.compiler }}
-      VCPKG_BUILD_TYPE: ${{ matrix.build_type }}
       VCPKG_DEFAULT_TRIPLET: ${{ matrix.triplet }}
       VCPKG_DISABLE_METRICS: true
 
@@ -59,11 +58,11 @@ jobs:
     - uses: friendlyanon/setup-vcpkg@v1
       with:
         committish: 2025.12.12
-        cache-key: vcpkg-${{ matrix.os }}-${{ matrix.os_version }}-${{ matrix.compiler }}-${{ matrix.build_type }}-${{ hashFiles('vcpkg.json', '.github/vcpkg_overlays/**') }}
-        ignore-reserve-cache-error: true
+        # vcpkg always builds release, so share cache between debug and release
+        cache-key: vcpkg-${{ matrix.os }}-${{ matrix.os_version }}-${{ matrix.compiler }}-${{ hashFiles('vcpkg.json', '.github/vcpkg_overlays/**') }}
 
-    - run: cmake --preset default
-
-    - run: cmake --build --parallel --preset default
-
-    - run: ctest --preset default --output-on-failure
+    - name: cmake
+      run: |
+        cmake --preset ${{ matrix.variant }}
+        cmake --build --parallel --preset ${{ matrix.variant }}
+        ctest --output-on-failure --preset ${{ matrix.variant }}

CMakePresets.json

@@ -7,24 +7,49 @@
   },
   "configurePresets": [
     {
-      "name": "default",
+      "name": "Release",
       "generator": "Ninja",
       "binaryDir": "${sourceDir}/build",
       "cacheVariables": {
+        "CMAKE_BUILD_TYPE": "Release",
+        "CMAKE_TOOLCHAIN_FILE": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"
+      }
+    },
+    {
+      "name": "Debug",
+      "generator": "Ninja",
+      "binaryDir": "${sourceDir}/build",
+      "cacheVariables": {
+        "CMAKE_BUILD_TYPE": "Debug",
         "CMAKE_TOOLCHAIN_FILE": "$env{VCPKG_ROOT}/scripts/buildsystems/vcpkg.cmake"
       }
     }
   ],
   "buildPresets": [
     {
-      "name": "default",
-      "configurePreset": "default"
+      "name": "Release",
+      "configurePreset": "Release"
+    },
+    {
+      "name": "Debug",
+      "configurePreset": "Debug"
     }
   ],
   "testPresets": [
     {
-      "name": "default",
-      "configurePreset": "default",
+      "name": "Release",
+      "configurePreset": "Release",
+      "output": {
+        "outputOnFailure": true
+      },
+      "execution": {
+        "noTestsAction": "error",
+        "stopOnFailure": true
+      }
+    },
+    {
+      "name": "Debug",
+      "configurePreset": "Debug",
       "output": {
         "outputOnFailure": true
       },