fix(deeplink): prevent deadlock in pause/resume actions

Author: Sadik111

apps/desktop/src-tauri/src/deeplink_actions.rs

@@ -162,27 +162,76 @@ impl DeepLinkAction {
             }
             DeepLinkAction::PauseRecording => {
                 let state = app.state::<ArcLock<App>>();
-                let guard = state.read().await;
-                if let Some(recording) = guard.current_recording() {
-                    recording.pause().await.map_err(|e| e.to_string())
-                } else {
-                    Ok(())
+                let (instant_handle, studio_handle) = {
+                    let guard = state.read().await;
+                    match guard.current_recording() {
+                        Some(crate::recording::InProgressRecording::Instant { handle, .. }) => {
+                            (Some(handle.clone()), None)
+                        }
+                        Some(crate::recording::InProgressRecording::Studio { handle, .. }) => {
+                            (None, Some(handle.clone()))
+                        }
+                        None => (None, None),
+                    }
+                };
+
+                if let Some(handle) = instant_handle {
+                    handle.pause().await.map_err(|e| e.to_string())?;
+                }
+                if let Some(handle) = studio_handle {
+                    handle.pause().await.map_err(|e| e.to_string())?;
                 }
+                Ok(())
             }
             DeepLinkAction::ResumeRecording => {
                 let state = app.state::<ArcLock<App>>();
-                let guard = state.read().await;
-                if let Some(recording) = guard.current_recording() {
-                    recording.resume().await.map_err(|e| e.to_string())
-                } else {
-                    Ok(())
+                let (instant_handle, studio_handle) = {
+                    let guard = state.read().await;
+                    match guard.current_recording() {
+                        Some(crate::recording::InProgressRecording::Instant { handle, .. }) => {
+                            (Some(handle.clone()), None)
+                        }
+                        Some(crate::recording::InProgressRecording::Studio { handle, .. }) => {
+                            (None, Some(handle.clone()))
+                        }
+                        None => (None, None),
+                    }
+                };
+
+                if let Some(handle) = instant_handle {
+                    handle.resume().await.map_err(|e| e.to_string())?;
                 }
+                if let Some(handle) = studio_handle {
+                    handle.resume().await.map_err(|e| e.to_string())?;
+                }
+                Ok(())
             }
             DeepLinkAction::SwitchMicrophone { mic_label } => {
+                if let Some(ref label) = mic_label {
+                    let available_mics = cap_recording::feeds::microphone::MicrophoneFeed::list();
+                    if !available_mics.contains_key(label) {
+                        return Err(format!("Microphone with label \"{}\" not found", label));
+                    }
+                }
+
                 let state = app.state::<ArcLock<App>>();
                 crate::set_mic_input(state, mic_label).await
             }
             DeepLinkAction::SwitchCamera { camera } => {
+                if let Some(ref id) = camera {
+                    let cameras: Vec<_> = cap_camera::list_cameras().collect();
+                    let exists = cameras.iter().any(|info| match id {
+                        DeviceOrModelID::DeviceID(device_id) => info.device_id() == device_id,
+                        DeviceOrModelID::ModelID(model_id) => {
+                            info.model_id().is_some_and(|existing| existing == model_id)
+                        }
+                    });
+
+                    if !exists {
+                        return Err(format!("Camera with ID \"{:?}\" not found", id));
+                    }
+                }
+
                 let state = app.state::<ArcLock<App>>();
                 crate::set_camera_input(app.clone(), state, camera).await
             }