fix(scripts): Fix mixing implicit and explicit returns (#47)

anchildress1 · web-flow · commit 8ebc66c435dc · 2026-01-18T09:24:17.000-05:00
* fix(scripts): Fix mixing implicit and explicit returns in _fetch_full_article_json

- Add explicit return None for max_retries &lt; 1 to avoid implicit fall-through
- Ensure all code paths in _fetch_full_article_json return explicitly

Generated-by: GitHub Copilot &lt;copilot@github.com&gt;
Signed-off-by: Ashley Childress &lt;6563688+anchildress1@users.noreply.github.com&gt;

* style(scripts): Remove dead return statement in _fetch_full_article_json

- The return None after the loop was unreachable since all execution paths return explicitly

Commit-generated-by

Signed-off-by: Ashley Childress &lt;6563688+anchildress1@users.noreply.github.com&gt;

---------

Signed-off-by: Ashley Childress &lt;6563688+anchildress1@users.noreply.github.com&gt;
diff --git a/scripts/generate_site.py b/scripts/generate_site.py
@@ -168,6 +168,11 @@ def _fetch_full_article_json(
     timeout: int = 30,
     initial_retry_delay: int = 2,
 ) -> dict | None:
+    # Defensive: if the caller asks for zero attempts, be explicit about returning None.
+    # (Avoids mixing explicit and implicit returns.)
+    if max_retries < 1:
+        return None
+
     retry_delay = initial_retry_delay
     for attempt in range(max_retries):
         try:
@@ -176,7 +181,7 @@ def _fetch_full_article_json(
             return full_response.json()
         except (requests.exceptions.ReadTimeout, requests.exceptions.ConnectionError) as e:
             if attempt < max_retries - 1:
-                print(f"  ⚠️  Timeout/connection error on attempt {attempt + 1}, " f"retrying in {retry_delay}s...")
+                print(f"  ⚠️  Timeout/connection error on attempt {attempt + 1}, retrying in {retry_delay}s...")
                 time.sleep(retry_delay)
                 retry_delay *= 2  # Exponential backoff
                 continue
@@ -351,8 +356,7 @@ def fetch_all_articles_from_api(last_run_iso=None) -> FetchArticlesResult:
 # Get the post template (from file or inline fallback)
 PAGE_TMPL = get_post_template()
 
-COMMENT_NOTE_TMPL = env.from_string(
-    """<!doctype html><html lang="en"><head>
+COMMENT_NOTE_TMPL = env.from_string("""<!doctype html><html lang="en"><head>
 <meta charset="utf-8">
 <title>{{ title }}</title>
 <link rel="canonical" href="{{ canonical }}">
@@ -405,8 +409,7 @@ def fetch_all_articles_from_api(last_run_iso=None) -> FetchArticlesResult:
   <p><a href="{{ url }}">Open on Dev.to →</a></p>
 </main>
 </body></html>
-"""
-)
+""")
 
 
 # ----------------------------
