Skip to content

HorizontalCard: No click response when isSelectable is false #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amogh-Bharadwaj wants to merge 2 commits into
base: main
Choose a base branch
from
Open

HorizontalCard: No click response when isSelectable is false #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b7248d
add read only field to card
Amogh-Bharadwaj Jan 7, 2026
af8e621
instead make isSelectable behave as readOnly
Amogh-Bharadwaj Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/components/CardHorizontal/CardHorizontal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,4 +187,18 @@ describe("CardHorizontal Component", () => {
expect(windowOpenSpy).not.toHaveBeenCalled();
windowOpenSpy.mockRestore();
});

it("should not call onClick when isSelectable is false", () => {
const onClickMock = vitest.fn();
const { container } = renderCard({
title: "Test Card",
isSelectable: false,
onButtonClick: onClickMock,
});

const wrapper = container.firstChild as HTMLElement;
wrapper.click();

expect(onClickMock).not.toHaveBeenCalled();
});
});
2 changes: 1 addition & 1 deletion src/components/CardHorizontal/CardHorizontal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ export const CardHorizontal = ({
...props
}: CardHorizontalProps) => {
const handleClick = (e: React.MouseEvent<HTMLElement>) => {
if (disabled) {
if (disabled || !isSelectable) {
e.preventDefault();
return;
}
Expand Down