auto review

Author: dubloom

ext/live_debugger.c

@@ -391,16 +391,14 @@ static void dd_log_probe_ensure_payload(dd_log_probe_dyn *dyn, dd_log_probe_def
     if (dyn->payload) {
         ddog_update_payload_message(dyn->payload, *msg);
     } else {
-        zend_string *process_tags = ddtrace_process_tags_get_serialized();
-
         dyn->service = ddtrace_active_service_name();
         dyn->payload = ddog_create_log_probe_snapshot(
             &def->parent.probe,
             msg,
             dd_zend_string_to_CharSlice(dyn->service),
             DDOG_CHARSLICE_C("php"),
             ddtrace_nanoseconds_realtime() / 1000000,
-            process_tags ? dd_zend_string_to_CharSlice(process_tags) : DDOG_CHARSLICE_C(""));
+            ddtrace_process_tags_get_serialized());
     }
 }
 

ext/process_tags.c

@@ -193,7 +193,7 @@ static void serialize_process_tags(void) {
 }
 
 zend_string *ddtrace_process_tags_get_serialized(void) {
-    return (ddtrace_process_tags_enabled() && process_tags.serialized) ? process_tags.serialized : NULL;
+    return (ddtrace_process_tags_enabled() && process_tags.serialized) ? process_tags.serialized : ZSTR_EMPTY_ALLOC();
 }
 
 bool ddtrace_process_tags_enabled(void){

ext/span.c

@@ -1114,14 +1114,7 @@ void ddtrace_serialize_closed_spans(ddog_TracesBytes *traces, bool fast_shutdown
                 do {
                     ddtrace_span_data *tmp = span;
                     span = tmp->next;
-                    bool is_first_span = (ddog_get_trace_size(trace) == 0);
-                    ddog_SpanBytes *rust_span = ddtrace_serialize_span_to_rust_span(tmp, trace);
-                    if (is_first_span) {
-                        zend_string *process_tags = ddtrace_process_tags_get_serialized();
-                        if (process_tags) {
-                            ddog_add_str_span_meta_zstr(rust_span, "_dd.process_tags", process_tags);
-                        }
-                    }
+                    ddtrace_serialize_span_to_rust_span(tmp, trace);
 #if PHP_VERSION_ID < 70400
                     // remove the artificially increased RC while closing again
                     GC_SET_REFCOUNT(&tmp->std, GC_REFCOUNT(&tmp->std) - DD_RC_CLOSED_MARKER);