Skip to content

fix(tracing): hook is_internal was backwards #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrisonlevi merged 1 commit into from
Feb 5, 2026
+1 −1
Merged

fix(tracing): hook is_internal was backwards #3625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zend_abstract_interface/hook/hook.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ static void zai_hook_resolve_hooks_entry(zai_hooks_entry *hooks, zend_function *
hooks->run_time_cache = ZEND_MAP_PTR(resolved->common.run_time_cache);
#endif
}
hooks->is_internal = ZEND_USER_CODE(resolved->type);
hooks->is_internal = !ZEND_USER_CODE(resolved->type);
hooks->is_generator = (resolved->common.fn_flags & ZEND_ACC_GENERATOR) != 0;
if (hooks->is_generator) {
#if ZAI_JIT_BLACKLIST_ACTIVE
Expand Down
Loading