Passing StorableCallback by reference where possible to reduce reference counting.

Author: Dawoodoz

Source/DFPSR/api/soundAPI.cpp

@@ -8,7 +8,7 @@
 namespace dsr {
 
 // See the Source/soundManagers folder for implementations of sound_streamToSpeakers for different operating systems.
-bool sound_streamToSpeakers_fixed(int32_t channels, int32_t sampleRate, int32_t periodSamplesPerChannel, StorableCallback<bool(SafePointer<float> fixedTarget)> soundOutput) {
+bool sound_streamToSpeakers_fixed(int32_t channels, int32_t sampleRate, int32_t periodSamplesPerChannel, const StorableCallback<bool(SafePointer<float> fixedTarget)> &soundOutput) {
 	int32_t bufferSamplesPerChannel = 0;
 	int32_t blockBytes = channels * sizeof(float);
 	Buffer fixedBuffer;

Source/DFPSR/api/soundAPI.h

@@ -26,14 +26,14 @@ namespace dsr {
 	//   Call sound_streamToSpeakers with desired channels and sampleRate from a separate thread.
 	//   Handle callbacks to soundOutput by feeding the next packed sound samples and letting it return false when done.
 	//   Close the thread and let the sound engine clean up resources.
-	bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, StorableCallback<bool(dsr::SafePointer<float> target, int32_t length)> soundOutput);
+	bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, const StorableCallback<bool(dsr::SafePointer<float> target, int32_t length)> &soundOutput);
 
 	// Wrapper for sound_streamToSpeakers to allow working with a fixed size period for better determinism across different hardware.
 	//   The target elements should be filled for indices 0 to (periodSamplesPerChannel * channels) - 1
 	// This allow using SIMD vectorization with a perfectly aligned period size without wasting any padding, even if the hardware's period size is an odd number.
 	// A fixed period can also be used for perfect timing when playing music.
 	// Pre-condition: periodSamplesPerChannel must be a power of two.
-	bool sound_streamToSpeakers_fixed(int32_t channels, int32_t sampleRate, int32_t periodSamplesPerChannel, StorableCallback<bool(dsr::SafePointer<float> fixedTarget)> soundOutput);
+	bool sound_streamToSpeakers_fixed(int32_t channels, int32_t sampleRate, int32_t periodSamplesPerChannel, const StorableCallback<bool(dsr::SafePointer<float> fixedTarget)> &soundOutput);
 
 	// A sound buffer with packed channels of 32-bit floats.
 	// The duration in seconds equals samplesPerChannel / sampleRate

Source/soundManagers/AlsaSound.cpp

@@ -30,7 +30,7 @@ static void terminateSound() {
 	}
 }
 
-bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, StorableCallback<bool(SafePointer<float> data, int32_t length)> soundOutput) {
+bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, const StorableCallback<bool(SafePointer<float> data, int32_t length)> &soundOutput) {
 	int errorCode;
 	if ((errorCode = snd_pcm_open(&pcm, "default", SND_PCM_STREAM_PLAYBACK, 0)) < 0) {
 		terminateSound();

Source/soundManagers/CoreAudioSound.cpp

@@ -107,7 +107,7 @@ static void initializeSound() {
 	playing = true;
 }
 
-bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, StorableCallback<bool(SafePointer<float> data, int32_t length)> soundOutput) {
+bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, const StorableCallback<bool(SafePointer<float> data, int32_t length)> &soundOutput) {
 	engineChannels = channels;
 	engineSampleRate = sampleRate;
 	engineCallback = soundOutput;

Source/soundManagers/NoSound.cpp

@@ -3,7 +3,7 @@
 
 namespace dsr {
 
-bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, StorableCallback<bool(SafePointer<float>, int32_t)> soundOutput) {
+bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, const StorableCallback<bool(SafePointer<float>, int32_t)> &soundOutput) {
 	return false;
 }
 

Source/soundManagers/WinMMSound.cpp

@@ -53,7 +53,7 @@ static void terminateSound() {
 	}
 }
 
-bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, StorableCallback<bool(SafePointer<float> data, int32_t length)> soundOutput) {
+bool sound_streamToSpeakers(int32_t channels, int32_t sampleRate, const StorableCallback<bool(SafePointer<float> data, int32_t length)> &soundOutput) {
 	bufferEndEvent = CreateEvent(0, FALSE, FALSE, 0);
 	if (bufferEndEvent == 0) {
 		terminateSound();