-
Notifications
You must be signed in to change notification settings - Fork 68
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Context: https://discord.com/channels/593902898015109131/1443144692006129684/1458732737295810623
Currently we don't "bail" if the callbacks takes too long and cause us to pass the "waitPoint" deadline. instead we poll to exhaustion. we could improve this further by stopping the poll if we passed the waitPoint in the middle of for_each_popping or even the functors themselves.
Note: this improvement is independant of whether the functor returns bool or not (bailing vs non bailing)
- two improvements could be made:
- pass singleWaitTimePt to for_each_popping and the functors
- be able to bail mid functor and keep the remainder of functor
then I guess we could rewrite both paths to:
- query the semaphore
- run all functors as at least timepoint bailing up to queried value
- wait for remaining signal values in order same as the bailing case
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request