feat: Delete APK on successful install

Iamlooker · Iamlooker · commit 071198b57053 · 2026-02-03T21:02:01.000+05:30
Closes #1000 Signed-off-by: LooKeR <iamlooker@proton.me>
diff --git a/app/src/main/kotlin/com/looker/droidify/datastore/PreferenceSettingsRepository.kt b/app/src/main/kotlin/com/looker/droidify/datastore/PreferenceSettingsRepository.kt
@@ -182,6 +182,9 @@ class PreferenceSettingsRepository(
         return repoId in data.first().enabledRepoIds
     }
 
+    override suspend fun setDeleteApkOnInstall(enable: Boolean) =
+        DELETE_APK_ON_INSTALL.update(enable)
+
     private fun mapSettings(preferences: Preferences): Settings {
         val installerType =
             InstallerType.valueOf(preferences[INSTALLER_TYPE] ?: InstallerType.Default.name)
@@ -223,6 +226,7 @@ class PreferenceSettingsRepository(
         val homeScreenSwiping = preferences[HOME_SCREEN_SWIPING] ?: true
         val enabledRepoIds =
             preferences[ENABLED_REPO_IDS]?.mapNotNull { it.toIntOrNull() }?.toSet() ?: emptySet()
+        val deleteApkOnInstall = preferences[DELETE_APK_ON_INSTALL] ?: false
 
         return Settings(
             language = language,
@@ -245,6 +249,7 @@ class PreferenceSettingsRepository(
             favouriteApps = favouriteApps,
             homeScreenSwiping = homeScreenSwiping,
             enabledRepoIds = enabledRepoIds,
+            deleteApkOnInstall = deleteApkOnInstall,
         )
     }
 
@@ -270,6 +275,7 @@ class PreferenceSettingsRepository(
         val LAST_MODIFIED_DS = longPreferencesKey("key_last_modified_download_stats")
         val FAVOURITE_APPS = stringSetPreferencesKey("key_favourite_apps")
         val HOME_SCREEN_SWIPING = booleanPreferencesKey("key_home_swiping")
+        val DELETE_APK_ON_INSTALL = booleanPreferencesKey("key_delete_apk_on_install")
         val LEGACY_INSTALLER_COMPONENT_CLASS =
             stringPreferencesKey("key_legacy_installer_component_class")
         val LEGACY_INSTALLER_COMPONENT_ACTIVITY =
@@ -334,6 +340,7 @@ class PreferenceSettingsRepository(
             set(FAVOURITE_APPS, settings.favouriteApps)
             set(HOME_SCREEN_SWIPING, settings.homeScreenSwiping)
             set(ENABLED_REPO_IDS, settings.enabledRepoIds.map { it.toString() }.toSet())
+            set(DELETE_APK_ON_INSTALL, settings.deleteApkOnInstall)
             return this.toPreferences()
         }
     }
diff --git a/app/src/main/kotlin/com/looker/droidify/datastore/Settings.kt b/app/src/main/kotlin/com/looker/droidify/datastore/Settings.kt
@@ -47,6 +47,7 @@ data class Settings(
     val favouriteApps: Set<String> = emptySet(),
     val homeScreenSwiping: Boolean = true,
     val enabledRepoIds: Set<Int> = emptySet(),
+    val deleteApkOnInstall: Boolean = false,
 )
 
 @OptIn(ExperimentalSerializationApi::class)
diff --git a/app/src/main/kotlin/com/looker/droidify/datastore/SettingsRepository.kt b/app/src/main/kotlin/com/looker/droidify/datastore/SettingsRepository.kt
@@ -70,6 +70,8 @@ interface SettingsRepository {
     fun getEnabledRepoIds(): Flow<Set<Int>>
 
     suspend fun isRepoEnabled(repoId: Int): Boolean
+
+    suspend fun setDeleteApkOnInstall(enable: Boolean)
 }
 
 inline fun <T> SettingsRepository.get(crossinline block: suspend Settings.() -> T): Flow<T> {
diff --git a/app/src/main/kotlin/com/looker/droidify/installer/InstallManager.kt b/app/src/main/kotlin/com/looker/droidify/installer/InstallManager.kt
@@ -15,6 +15,7 @@ import com.looker.droidify.installer.model.InstallItem
 import com.looker.droidify.installer.model.InstallState
 import com.looker.droidify.service.SyncService
 import com.looker.droidify.utility.common.Constants
+import com.looker.droidify.utility.common.cache.Cache
 import com.looker.droidify.utility.common.extension.addAndCompute
 import com.looker.droidify.utility.common.extension.filter
 import com.looker.droidify.utility.common.extension.notificationManager
@@ -55,6 +56,7 @@ class InstallManager(
     private val lock = Mutex()
     private val skipSignature = settingsRepository.get { ignoreSignature }
     private val installerPreference = settingsRepository.get { installerType }
+    private val deleteApkPreference = settingsRepository.get { deleteApkOnInstall }
     private val notificationManager by lazy { context.notificationManager }
 
     suspend operator fun invoke() = coroutineScope {
@@ -104,6 +106,12 @@ class InstallManager(
                     )
                 )
                 val success = installer.use { it.install(item) }
+                if (success == InstallState.Installed) {
+                    if (deleteApkPreference.first()) {
+                        val apkFile = Cache.getReleaseFile(context, item.installFileName)
+                        apkFile.delete()
+                    }
+                }
                 if (success == InstallState.Installed && SyncService.autoUpdating) {
                     val updates = Database.ProductAdapter.getUpdates(skipSignature.first())
                     when {
diff --git a/app/src/main/kotlin/com/looker/droidify/ui/settings/SettingsFragment.kt b/app/src/main/kotlin/com/looker/droidify/ui/settings/SettingsFragment.kt
@@ -49,12 +49,12 @@ import com.looker.droidify.utility.common.extension.updateAsMutable
 import com.looker.droidify.utility.common.isIgnoreBatteryEnabled
 import com.looker.droidify.utility.common.requestBatteryFreedom
 import dagger.hilt.android.AndroidEntryPoint
-import kotlinx.coroutines.flow.Flow
-import kotlinx.coroutines.launch
-import java.util.Locale
+import java.util.*
 import kotlin.time.Duration
 import kotlin.time.Duration.Companion.days
 import kotlin.time.Duration.Companion.hours
+import kotlinx.coroutines.flow.Flow
+import kotlinx.coroutines.launch
 import com.google.android.material.R as MaterialR
 
 @AndroidEntryPoint
@@ -283,6 +283,11 @@ class SettingsFragment : Fragment() {
                     onClick = { viewModel.setLegacyInstallerComponentComponent(it) },
                 )
             }
+            deleteApkOnInstall.connect(
+                titleText = getString(R.string.delete_apk_on_install),
+                contentText = getString(R.string.delete_apk_on_install_summary),
+                setting = viewModel.getInitialSetting { deleteApkOnInstall },
+            )
             incompatibleUpdates.connect(
                 titleText = getString(R.string.incompatible_versions),
                 contentText = getString(R.string.incompatible_versions_summary),
@@ -413,6 +418,9 @@ class SettingsFragment : Fragment() {
             incompatibleUpdates.checked.setOnCheckedChangeListener { _, checked ->
                 viewModel.setIncompatibleUpdates(checked)
             }
+            deleteApkOnInstall.checked.setOnCheckedChangeListener { _, checked ->
+                viewModel.setDeleteApkOnInstall(checked)
+            }
             forceCleanUp.root.setOnClickListener {
                 viewModel.forceCleanup(it.context)
             }
diff --git a/app/src/main/kotlin/com/looker/droidify/ui/settings/SettingsViewModel.kt b/app/src/main/kotlin/com/looker/droidify/ui/settings/SettingsViewModel.kt
@@ -28,15 +28,15 @@ import com.looker.droidify.installer.installers.isShizukuInstalled
 import com.looker.droidify.installer.installers.requestPermissionListener
 import com.looker.droidify.work.CleanUpWorker
 import dagger.hilt.android.lifecycle.HiltViewModel
+import java.util.*
+import javax.inject.Inject
+import kotlin.time.Duration
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.flow.asSharedFlow
 import kotlinx.coroutines.flow.flow
 import kotlinx.coroutines.flow.map
 import kotlinx.coroutines.launch
-import java.util.Locale
-import javax.inject.Inject
-import kotlin.time.Duration
 
 @HiltViewModel
 class SettingsViewModel
@@ -199,6 +199,12 @@ class SettingsViewModel
         }
     }
 
+    fun setDeleteApkOnInstall(enable: Boolean) {
+        viewModelScope.launch {
+            settingsRepository.setDeleteApkOnInstall(enable)
+        }
+    }
+
     fun exportSettings(file: Uri) {
         viewModelScope.launch {
             settingsRepository.export(file)
diff --git a/app/src/main/res/layout/settings_page.xml b/app/src/main/res/layout/settings_page.xml
@@ -148,6 +148,9 @@
             <include
                 android:id="@+id/legacy_installer_component"
                 layout="@layout/enum_type" />
+            <include
+                android:id="@+id/delete_apk_on_install"
+                layout="@layout/switch_type" />
 
             <TextView
                 android:layout_width="match_parent"
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -105,6 +105,8 @@
     <string name="install_types">Installation</string>
     <string name="installer">Installer</string>
     <string name="legacyInstallerComponent">Legacy installer component</string>
+    <string name="delete_apk_on_install">Delete APK on install</string>
+    <string name="delete_apk_on_install_summary">Automatically delete APK files after successful installation</string>
     <string name="unspecified">Unspecified</string>
     <string name="insufficient_storage">Insufficient space</string>
     <string name="insufficient_storage_DESC">There isn\'t enough free space to install this app</string>

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ data class Settings(`
`47`	`47`	`val favouriteApps: Set<String> = emptySet(),`
`48`	`48`	`val homeScreenSwiping: Boolean = true,`
`49`	`49`	`val enabledRepoIds: Set<Int> = emptySet(),`
	`50`	`+ val deleteApkOnInstall: Boolean = false,`
`50`	`51`	`)`
`51`	`52`
`52`	`53`	`@OptIn(ExperimentalSerializationApi::class)`
Original file line number	Diff line number	Diff line change
`@@ -70,6 +70,8 @@ interface SettingsRepository {`
`70`	`70`	`fun getEnabledRepoIds(): Flow<Set<Int>>`
`71`	`71`
`72`	`72`	`suspend fun isRepoEnabled(repoId: Int): Boolean`
	`73`	`+`
	`74`	`+ suspend fun setDeleteApkOnInstall(enable: Boolean)`
`73`	`75`	`}`
`74`	`76`
`75`	`77`	`inline fun <T> SettingsRepository.get(crossinline block: suspend Settings.() -> T): Flow<T> {`