fix memory issues

Author: markaren

src/ecos/scenario/parse_scenario_node.hpp

@@ -10,7 +10,7 @@
 
 inline std::unique_ptr<ecos::scenario> parse_scenario_node(const pugi::xml_node& root, size_t& numActions)
 {
-    std::unique_ptr<ecos::scenario> parsed_scenario;
+    auto parsed_scenario = std::make_unique<ecos::scenario>();
 
     if (const auto nameAttr = root.attribute("name")) {
         parsed_scenario->name = nameAttr.as_string();

src/ecos/ssp/ssp_loader.cpp

@@ -76,16 +76,15 @@ class ssp_based_simulation_structure : public simulation_structure
         }
 
         if (auto ex = desc_.defaultExperiment) {
-            auto annotations = ex->annotations;
+            const auto& annotations = ex->annotations;
             for (const auto& annotation : annotations) {
                 if (annotation.type == "com.github.ecos-platform.scenario") {
 
-
                     size_t numActions{};
                     const auto root = annotation.node.child("ecos:Scenario");
                     auto parsed_scenario = parse_scenario_node(root, numActions);
+                    log::debug("Adding scenario '{}' with {} actions to SystemStructure", parsed_scenario->name, numActions);
                     add_scenario(std::move(parsed_scenario));
-                    log::debug("Added scenario '{}' with {} actions to SystemStructure", parsed_scenario->name, numActions);
                 }
             }
         }