Merged
Conversation
6 tasks
samholmes
requested changes
Apr 24, 2025
Contributor
There was a problem hiding this comment.
Thank you for the PR!
Happy to accept this PR, however I have some feedback to address first.
In addition to the changes requested, you may squash the commits prior to "add eCash support to plugin" commit together with it. Those commit seem to make sense combined with the last commit.
samholmes
reviewed
Apr 24, 2025
Amatack
force-pushed
the
feat/ecash-integration
branch
from
5a2b173 to
5a01356
Compare
samholmes
approved these changes
May 7, 2025
Contributor
samholmes
left a comment
samholmes
left a comment
There was a problem hiding this comment.
Perfect! Thanks for the updates and much appreciation for the contribution. This is mergeable.
Contributor
|
Final fixup request: Could you add this entry to the CHANGELOG to the "Add eCash support to plugin" commit: This PR does warrant an entry to the CHANGELOG. |
-Implement key, WIF, and address conversions for eCash -Validate eCash addresses and reject non-eCash addresses -Address review feedback
Amatack
force-pushed
the
feat/ecash-integration
branch
from
5a01356 to
ffb6164
Compare
Contributor
Author
|
Done, I've added the CHANGELOG entry as requested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Description
Changes add eCash (XEC) support to the plugin