Conversation
samholmes
force-pushed
the
sam/unexpected-error
branch
from
493f1a7 to
bba0718
Compare
Jon-edge
approved these changes
Oct 28, 2025
Contributor
Author
|
Approved the last two commits OTS with @Jon-edge |
This relax on whether existing records follow the valid shape defined by the cleaners is only because during development, the underlying types change and cause a permanently broken state for the account. In the future, we can harden this API to throw an error to not risk losing data if we desire to.
samholmes
force-pushed
the
sam/unexpected-error
branch
from
6c06dd4 to
adcdbe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Adjust Infinite dummy TOS/status handling and add customer PENDING status; EdgeVault now safely returns undefined on invalid records.
getTosnow randomly returnsstatusasacceptedorpendinginstead of alwayspendinginsrc/plugins/ramps/infinite/infiniteApi.ts.PENDINGtoasInfiniteCustomerStatusinsrc/plugins/ramps/infinite/infiniteApiTypes.ts.getExistingRecordinsrc/util/vault/edgeVault.tsnow catches parse errors and may returnundefined, updating its return type accordingly.Written by Cursor Bugbot for commit adcdbe6. This will update automatically on new commits. Configure here.