Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // | ||
| // Banxa | ||
| // | ||
|
|
||
| // Disable Banxa completely | ||
| if (params.rampPluginId === 'banxa') { | ||
| yield false | ||
| } |
There was a problem hiding this comment.
Adding yield false disables Banxa only at the constraint level, but the Banxa plugin’s checkSupport and fetchQuotes both call fetchProviderConfig() before validateRamp* is invoked. With Banxa supposed to be offline, these calls still hit Banxa’s APIs and will throw, and useRampQuotes surfaces those errors to the user even though the provider is meant to be disabled. The constraint should short‑circuit before any network work or the plugin should be omitted entirely so that disabling Banxa does not keep producing visible errors or network traffic.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
With the current change, Banxa will be filtered out by supported-plugins before quotes run, so no Banxa errors are shown to the user.
There was a problem hiding this comment.
Isn't the ask to only disable ACH for banxa not banxa completely?
| // | ||
| // Banxa | ||
| // | ||
|
|
||
| // Disable Banxa completely | ||
| if (params.rampPluginId === 'banxa') { | ||
| yield false | ||
| } |
There was a problem hiding this comment.
Isn't the ask to only disable ACH for banxa not banxa completely?
|
Yep, verified that the task is only to disable ACH due to bank workflow issues |
src/plugins/ramps/rampConstraints.ts
Outdated
| // Banxa | ||
| // | ||
|
|
||
| // Disable Banxa completely |
There was a problem hiding this comment.
Change comment to reflect the fixup!
Jon-edge
force-pushed
the
jon/disable-banxa
branch
from
2412adf to
797b21d
Compare
2 participants
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Disables
achpayment type forbanxain ramp constraints.src/plugins/ramps/rampConstraints.ts):achpayment type via new constraint inconstraintGenerator.Written by Cursor Bugbot for commit 797b21d. This will update automatically on new commits. Configure here.