Conversation
Contributor
Author
|
@swansontec I'm okay with removing some of the refactor for staging and instead punt it to develop if you don't think its safe enough |
swansontec
approved these changes
Nov 14, 2025
Contributor
swansontec
left a comment
There was a problem hiding this comment.
One AI comment should be looked at, but overall this is a good improvement.
1de63e6 to
0a43399
Compare
This is a more appropriate name for this field because of it's no longer simply an exchange amount.
This makes it clear what the expected units are.
0a43399 to
1f7fb6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Replaces
exchangeAmountwith newamountQuery(exact/max/maxExchangeAmount) across UI and ramp plugins, adding crypto-amount and robust MAX flow support (with caps) notably for Infinite.RampQuoteRequest.exchangeAmountwithamountQueryusingRampQouteAmount(exchangeAmount|max|maxExchangeAmount).amountQuery; remove references toRampExchangeAmount.src/components/scenes/RampCreateScene.tsx):amountQuery; adjust initial amount, MAX handling, and navigation auto-advance for max.amountQueryandmaxExchangeAmount.infiniteRampPlugin.ts):checkSupportnow reportssupportedAmountTypes: ['fiat','crypto'].fetchQuotessupports fiat/crypto amount types, MAX and capped MAX, validates against min/max, and buildssource/targetparams accordingly; maps response amounts safely; updates dev test path.amountQuery(exchangeAmount/max/maxExchangeAmount) for quotes; apply appropriate limit checks and MAX-cap logic.Written by Cursor Bugbot for commit 1f7fb6f. This will update automatically on new commits. Configure here.