Conversation
Jon-edge
reviewed
Nov 14, 2025
| if (beforeTransaction != null) await beforeTransaction() | ||
| } catch (e: unknown) { | ||
| console.error( | ||
| 'Error from before transaction route param hook: ', |
Collaborator
There was a problem hiding this comment.
Why are we not surfacing this error to the UI?
Contributor
Author
There was a problem hiding this comment.
Because it fails gracefully. This was the behavior. I have no idea why.
Collaborator
|
For visual changes, be sure to include a screenshot in the PR and mark which platforms were tested |
We can do this safely because unknown errors from makeSpend will result in `edgeTransaction == null`. This will allow for the slide to be enabled on errors/unknown-errors which can occur but may be intermittent.
samholmes
force-pushed
the
sam/send-scene-errors
branch
from
2c653b7 to
2e64e3d
Compare
Jon-edge
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Replaces SendScene2 error UI with ErrorCard and upgrades error handling (I18nError, specific cases, timeout), tweaks SafeSlider scheduling, and updates snapshots/CHANGELOG.
ErrorTilewithErrorCard; move error display outside the main card stack.unknown+I18nError; add targeted messaging (Algo recipient not activated, EOS CPU/NET/RAM, HTTP 504, insufficient funds with network context).I18nError; add logging aroundbeforeTransaction.runOnJSforscheduleOnRN; set completion state before callback.SendScene2snapshots to reflect layout/animation/icon changes and new error rendering.ErrorCardinSendScene2.Written by Cursor Bugbot for commit 2e64e3d. This will update automatically on new commits. Configure here.