feat: added WebApplicationBuilder overload, removed Obsolete attribute, removed static OnAppReadyCallback in favor of Events.OnReady

Author: Denny09310

src/ElectronNET.API/ElectronNetRuntime.cs

@@ -47,8 +47,6 @@ static ElectronNetRuntime()
 
         internal static int? ElectronProcessId { get; set; }
 
-        internal static Func<Task> OnAppReadyCallback { get; set; }
-
         /// <summary>
         /// Global configuration options for the Electron.NET runtime, including
         /// lifecycle events that can be configured from the ASP.NET host builder.

src/ElectronNET.AspNet/API/WebApplicationBuilderExtensions.cs

@@ -40,7 +40,18 @@ public static class WebApplicationBuilderExtensions
         /// </example>
         public static WebApplicationBuilder UseElectron(this WebApplicationBuilder builder, string[] args, Func<Task> onAppReadyCallback)
         {
-            builder.WebHost.UseElectron(args, onAppReadyCallback);
+            return UseElectron(builder, options =>
+            {
+                options.Events = new()
+                {
+                    OnReady = onAppReadyCallback
+                };
+            });
+        }
+
+        public static WebApplicationBuilder UseElectron(this WebApplicationBuilder builder, Action<ElectronNetOptions> configure)
+        {
+            builder.WebHost.UseElectron(configure);
 
             return builder;
         }

src/ElectronNET.AspNet/API/WebHostBuilderExtensions.cs

@@ -58,7 +58,6 @@ public static class WebHostBuilderExtensions
         /// }
         /// </code>
         /// </example>
-        [Obsolete("This method is deprecated. Please use the overload with the configure parameter")]
         public static IWebHostBuilder UseElectron(this IWebHostBuilder builder, string[] args, Func<Task> onAppReadyCallback)
         {
             if (onAppReadyCallback == null)
@@ -67,7 +66,7 @@ public static IWebHostBuilder UseElectron(this IWebHostBuilder builder, string[]
             }
 
             // Backwards compatible overload – wraps the single callback into the new options model.
-            return UseElectron(builder, args, options =>
+            return UseElectron(builder, options =>
             {
                 options.Events.OnReady = onAppReadyCallback;
             });
@@ -78,7 +77,7 @@ public static IWebHostBuilder UseElectron(this IWebHostBuilder builder, string[]
         /// configuration. The provided <see cref="ElectronNetOptions"/> allows registration of callbacks
         /// for different phases of the Electron runtime.
         /// </summary>
-        public static IWebHostBuilder UseElectron(this IWebHostBuilder builder, string[] args, Action<ElectronNetOptions> configure)
+        public static IWebHostBuilder UseElectron(this IWebHostBuilder builder, Action<ElectronNetOptions> configure)
         {
             if (configure == null)
             {
@@ -89,9 +88,6 @@ public static IWebHostBuilder UseElectron(this IWebHostBuilder builder, string[]
             configure(options);
             ElectronNetRuntime.Options = options;
 
-            // Preserve behaviour of the original API by mapping OnReady to the legacy callback.
-            ElectronNetRuntime.OnAppReadyCallback = options.Events?.OnReady;
-
             var webPort = PortHelper.GetFreePort(ElectronNetRuntime.AspNetWebPort ?? ElectronNetRuntime.DefaultWebPort);
             ElectronNetRuntime.AspNetWebPort = webPort;
 

src/ElectronNET.AspNet/Runtime/Controllers/RuntimeControllerAspNetBase.cs

@@ -183,15 +183,15 @@ private async Task RunReadyCallback()
                 }
             }
 
-            if (ElectronNetRuntime.OnAppReadyCallback == null)
+            if (events.OnReady == null)
             {
                 Console.WriteLine("Warning: Non OnReadyCallback provided in UseElectron() setup.");
                 return;
             }
 
             try
             {
-                await ElectronNetRuntime.OnAppReadyCallback().ConfigureAwait(false);
+                await events.OnReady().ConfigureAwait(false);
             }
             catch (Exception ex)
             {

src/ElectronNET.WebApp/Program.cs

@@ -20,7 +20,7 @@ public static IWebHostBuilder CreateWebHostBuilder(string[] args)
         {
             return WebHost.CreateDefaultBuilder(args)
                 .ConfigureLogging((hostingContext, logging) => { logging.AddConsole(); })
-                .UseElectron(args, ElectronBootstrap)
+                .UseElectron(ElectronBootstrap)
                 .UseStartup<Startup>();
         }