Skip to content

Commit 2a32b8c

Browse files
authored
Mitigate OTP TLS 1.3 bug leaking message (#149)
OTP ssl can leak a message `{Ref, ok}` when key update is triggered, if the bug erlang/otp#10273 is present. Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech>
1 parent 49ee6c7 commit 2a32b8c

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/ered_connection.erl

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -368,17 +368,17 @@ receive_data(0, _Time, Acc) ->
368368
{data, lists:unzip(lists:reverse(Acc))};
369369
receive_data(N, Time, Acc) ->
370370
receive
371-
Msg ->
372-
case Msg of
373-
{recv_exit, Reason} ->
374-
{recv_exit, Reason};
375-
{send, Pid, Ref, Commands} ->
376-
Data = ered_command:get_data(Commands),
377-
Class = ered_command:get_response_class(Commands),
378-
RefInfo = {Class, Pid, Ref, []},
379-
Acc1 = [{RefInfo, Data} | Acc],
380-
receive_data(N - 1, 0, Acc1)
381-
end
371+
{recv_exit, Reason} ->
372+
{recv_exit, Reason};
373+
{send, Pid, Ref, Commands} ->
374+
Data = ered_command:get_data(Commands),
375+
Class = ered_command:get_response_class(Commands),
376+
RefInfo = {Class, Pid, Ref, []},
377+
Acc1 = [{RefInfo, Data} | Acc],
378+
receive_data(N - 1, 0, Acc1);
379+
_Ignore ->
380+
%% Mitigate OTP TLS 1.3 bug #10273 leaking a message {Ref, ok}.
381+
receive_data(N, 0, Acc)
382382
after Time ->
383383
receive_data(0, 0, Acc)
384384
end.

0 commit comments

Comments
 (0)