fix: clippy and zig output

Author: Esubaalew

src/app.rs

@@ -244,8 +244,7 @@ fn install_package(language: &LanguageSpec, package: &str) -> Result<i32> {
             Ok(1)
         }
         Err(err) => {
-            return Err(err)
-                .with_context(|| format!("failed to run package manager for {lang_id}"));
+            Err(err).with_context(|| format!("failed to run package manager for {lang_id}"))
         }
     }
 }

src/cli.rs

@@ -203,7 +203,7 @@ pub fn parse() -> Result<Command> {
             _ => {
                 let mut all_tokens = Vec::with_capacity(trailing.len() + 1);
                 all_tokens.push(first);
-                all_tokens.extend(trailing.drain(..));
+                all_tokens.append(&mut trailing);
                 let (code_tokens, extra_args) = split_at_double_dash(&all_tokens);
                 let joined = join_tokens(&code_tokens);
                 source = Some(InputSource::Inline(joined));

src/engine/zig.rs

@@ -128,11 +128,24 @@ impl LanguageEngine for ZigEngine {
             let src_hash = hash_source(&snippet);
             if let Some(output) = try_cached_execution(src_hash) {
                 let start = Instant::now();
+                let mut stdout = String::from_utf8_lossy(&output.stdout).into_owned();
+                let stderr = String::from_utf8_lossy(&output.stderr).into_owned();
+                if output.status.success() && !stderr.contains("error:") {
+                    if stdout.is_empty() {
+                        stdout = stderr.clone();
+                    } else if !stderr.is_empty() {
+                        stdout.push_str(&stderr);
+                    }
+                }
                 return Ok(ExecutionOutcome {
                     language: self.id().to_string(),
                     exit_code: output.status.code(),
-                    stdout: String::from_utf8_lossy(&output.stdout).into_owned(),
-                    stderr: String::from_utf8_lossy(&output.stderr).into_owned(),
+                    stdout,
+                    stderr: if output.status.success() && !stderr.contains("error:") {
+                        String::new()
+                    } else {
+                        stderr
+                    },
                     duration: start.elapsed(),
                 });
             }
@@ -184,11 +197,24 @@ impl LanguageEngine for ZigEngine {
                     .stdin(Stdio::inherit());
                 if let Ok(output) = run_cmd.output() {
                     drop(temp_dir);
+                    let mut stdout = String::from_utf8_lossy(&output.stdout).into_owned();
+                    let stderr = String::from_utf8_lossy(&output.stderr).into_owned();
+                    if output.status.success() && !stderr.contains("error:") {
+                        if stdout.is_empty() {
+                            stdout = stderr.clone();
+                        } else if !stderr.is_empty() {
+                            stdout.push_str(&stderr);
+                        }
+                    }
                     return Ok(ExecutionOutcome {
                         language: self.id().to_string(),
                         exit_code: output.status.code(),
-                        stdout: String::from_utf8_lossy(&output.stdout).into_owned(),
-                        stderr: String::from_utf8_lossy(&output.stderr).into_owned(),
+                        stdout,
+                        stderr: if output.status.success() && !stderr.contains("error:") {
+                            String::new()
+                        } else {
+                            stderr
+                        },
                         duration: start.elapsed(),
                     });
                 }

src/repl.rs

@@ -984,8 +984,8 @@ fn python_dedent_one_level(indent: &str) -> String {
     if indent.is_empty() {
         return String::new();
     }
-    if indent.ends_with('\t') {
-        return indent[..indent.len() - 1].to_string();
+    if let Some(stripped) = indent.strip_suffix('\t') {
+        return stripped.to_string();
     }
     let mut trimmed = indent.to_string();
     let mut removed = 0usize;