Skip to content

Commit 4356c36

Browse files
authored
fix: regex match for keys rule (#180)
1 parent b1720d4 commit 4356c36

File tree

5 files changed

+6
-6
lines changed

5 files changed

+6
-6
lines changed

dist/index.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/index.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/rules/keys.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export const validateKeys = (packageJson: PackageJson, packageJsonPath: string)
2020
const dependencies = getDependencies(packageJson);
2121
Object.keys(dependencies).forEach(dependency => {
2222
const stringifiedPackageJson = readFileSync(packageJsonPath).toString();
23-
const regexMatches = stringifiedPackageJson.match(new RegExp(dependency, 'g'));
23+
const regexMatches = stringifiedPackageJson.match(new RegExp(`"${dependency}"`, 'g'));
2424
if (regexMatches && regexMatches.length > 1) {
2525
core.setFailed(`Duplicate keys found in package.json: ${regexMatches}`);
2626
}

test/fixtures/deduped-package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"dependencies": {
33
"some-dependency": "1.0.0",
4-
"some-other-dependency": "2.0.0"
4+
"some-dependency-2": "2.0.0"
55
},
66
"devDependencies": {
7-
"some-dev-dependency": "2.0.0"
7+
"some-dependency-3": "2.0.0"
88
}
99
}

test/fixtures/duped-package2.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"dependencies": {
33
"some-dependency": "1.0.0",
4-
"some-other-dependency": "2.0.0"
4+
"some-dependency-2": "2.0.0"
55
},
66
"devDependencies": {
77
"some-dependency": "2.0.0"

0 commit comments

Comments
 (0)