Skip to content

New extension: Create Objects Between Two Positions#573

Closed
github-actions[bot] wants to merge 1 commit intomainfrom
extension/User8426/572
Closed

New extension: Create Objects Between Two Positions#573
github-actions[bot] wants to merge 1 commit intomainfrom
extension/User8426/572

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 9, 2022

Description

This extensions makes it easier for a user to create a line of objects equally spaced apart between either two positions or two objects. Each event has a centered and non-centered version. This allows the user to place the objects by their origin or by their center.

How to use the extension

To use this sprite you can:

  1. Use the Create Objects Between Positions event and/or the centered version event. Select an object to be created, then select two positions to create between and a number of objects. Run the event and a line of objects will be made.
  2. Use the Create a Line of an Object Between Two Objects event and/or the centered version event. Select an object to be created, then select two objects to create the first object between. Run the event and a line of the first object will be made.

Checklist

  • I've followed all of the best practices.
  • I confirm that this extension can be integrated to this GitHub repository, distributed and MIT licensed.
  • I am aware that the extension may be updated by anyone, and do not need my explicit consent to do so.

What tier of review do you aim for your extension?

Reviewed

Example file

Example.zip

Extension file

CreateObjectsBetweenPositions.zip

@github-actions github-actions bot requested a review from a team as a code owner September 9, 2022 16:39
@github-actions github-actions bot added the ✨ New extension A new extension label Sep 9, 2022
@VegeTato
Copy link
Contributor

VegeTato commented Sep 9, 2022

Hello @User8426, Great extension ! ❤️
I noticed few things that need to be fixed:

• The total objects created between the marks are not the same as the one I pick, for example when I set the total created objects between 2 objects to 100, it will create 101 between them
when I set it to 1 it creates 2.

• when I set the total objects to 0, it creates 1 but invisible.

I noticed few things that need to be fixed, make sure to read the extension best practices here:
https://wiki.gdevelop.io/gdevelop5/extensions/best-practices

• The variables of the extension must follow the best practices, for example
your variable: ObjectsBetweenPositions.XChange should be replaced with __ObjectsBetweenPositions.XChange
double underscore is required, same thing apply to all your variables.

• Your description in every parameter should follow Pascal Case, for example:
Object To Create should be replaced with Object to create same thing apply to everything in the extension.

@VegeTato VegeTato added the 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. label Sep 9, 2022
@User8426
Copy link

User8426 commented Sep 9, 2022

Thanks for the review,

Apologies about the latter two issues, I read on best practices at one point that you shouldn't use private methods or variables so I assumed I shouldn't use __ and I haven't used Pascal Case much. I believe I've fixed all of the issues found in the review in this version.

Example -
Example.zip

Extension -
CreateObjectsBetweenPositions.zip

@arthuro555 arthuro555 added 🧪 Experimental extension An extension submission to be merged with a lightweight review. and removed 🔍 Reviewed extension An extension that is to be reviewed in great detail before merging. labels Dec 16, 2024
@arthuro555
Copy link
Member

This PR is looking dead, I'll close it, feel free to reopen if someone's getting back to it

@arthuro555 arthuro555 closed this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧪 Experimental extension An extension submission to be merged with a lightweight review. ✨ New extension A new extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants