Formulation for wave height is wrong in WaveMaker.cu (NEXT branch) #59
Description
I've been working the WaveMaker.cu test case a lot recently and I've encountered a bug in the way the wave height is defined.
On line 132: float wave_height = H*stroke/4;
Something is wrong here. The dimensions don't match up. Where does this equation come from? I want to know the reference source and equation number so I can double check what hidden assumptions are being made, what the theory behind it is, etc.
In addition to the bug above, I'm wondering what "setMaxFall" is (line 133)? This will obviously benefit from fixing the bug above, but I couldn't find any documentation, or comment in the code, explaining what this is. In the comments it does say "see e.g. Ch. 6 in Dean & Dalrymple, Water Waves Mechanics for Engineers and Scientists" ... but I'm assuming that's for the wave maker and not related to "setMaxFall"? So what is it?
Since I'm on the subject of the WaveMaker.cu test case...there is another issue that needs to be fixed.
On line 280: kdata.crot = make_double3(0.25f, m_deltap, 0.0f);
This is hard coded for the specific problem. I think we can both agree that the paddle origin is assumed as the axis of rotation. That being said, this should be fixed to read kdata.crot = paddle_origin; . If you intend to leave this a variable, then it should be assigned along with the other wave maker properties, not hidden in the callback.