Skip to content

Inconsistency with ListFieldBloc#updateFieldBlocs #346

@Zekfad

Description

@Zekfad

I've tried to use ReorderableListView with ListFieldBloc and found following inconsistency:

final shapes = ListFieldBloc<ShapePropertiesBloc, void>();

This one produces incorrect results inconsistently

  void reorderShape(int oldIndex, int newIndex) {
    final blocs = shapes.state.fieldBlocs;
    final shapeBloc = blocs.removeAt(oldIndex);
    blocs.insert(
      oldIndex < newIndex
        ? newIndex - 1
        : newIndex,
      shapeBloc,
    );
    shapes.updateFieldBlocs(blocs);
  }

This method produces correct results, but creates a junk frames due to double emit.

  void reorderShape(int oldIndex, int newIndex) {
     shapes
      ..removeFieldBlocAt(oldIndex)
      ..insertFieldBloc(
        shapeBloc,
        oldIndex < newIndex
          ? newIndex - 1
          : newIndex,
      );
  }

I suspect issue is with order of FormBlocUtils calls, because they are different if I use patch method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions