Commit 85c7ca5
committed
test(): clean up bulkMembers tests and fix claim test isolation issue
- Simplified DirectPayments.bulkMembers.test.ts by removing unnecessary
custom validator creation and using existing fixture mocks with proper
withArgs configuration
- Simplified UBIPool.bulkMembers.test.ts by removing custom validator
creation in validation tests and using fixture mocks instead
- Changed UBIPool uniqueness validation test to use signers[5-7] instead
of signers[2-4] to avoid mock conflicts with other tests
- Fixed DirectPayments.claim.test.ts "non member should not be able to
get rewards" test by explicitly setting uniquenessValidator to AddressZero
to prevent "Mock on the method is not initialized" error when running
all tests together
The claim test was failing when run with other tests because it inherited
uniqueness validator mock state without proper initialization for the test's
specific address. Setting uniquenessValidator to zero address ensures proper
test isolation and bypasses uniqueness validation, which is appropriate
since this test only validates member validation logic.1 parent d00a17d commit 85c7ca5
File tree
1 file changed
+1
-1
lines changed- packages/contracts/test/DirectPayments
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | | - | |
| 178 | + | |
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
| |||
0 commit comments