Error when trying to replace a file through web interface

[bjosel]

What steps does it take to reproduce the issue?

1. Replace a .txt file via the browser
2. Drag-n-drop or select the new file to replace the old file.

• When does this issue occur?
  When trying to replace a file through the Dataverse web interface. Tested on various file formats (text, pdf, picture)

• Which page(s) does it occurs on?
  dataset.xhtml, editdatafiles.xhtml

• What happens?
  An error is shown "You cannot add Tabular Data Tags to a non-tabular file" and file replacement is stopped

• To whom does it occur (all users, curators, superusers)?
  all users (tested with superuser, researcher, admin)

• What did you expect to happen?
  The file should be replaced successfully

Which version of Dataverse are you using?
v6.8

Any related open or closed issues to this bug report?
Maybe #11972 (wild guess due to the error message mentioning tags)

Screenshots:

Are you thinking about creating a pull request for this issue?
We are looking into it but haven't identified nor fixed the problem

[pdurbin]

@bjosel thanks for the bug report. Are you able to reproduce the bug on https://demo.dataverse.org ?

[bjosel]

Hi @pdurbin,
yes I can reproduce on demo.dataverse.org. See screenshot

[pdurbin]

@bjosel d'oh! Thanks for testing! Can you please also try it in the new UI at https://beta.dataverse.org/spa/ ?

[bjosel]

@pdurbin On the new UI there was no error. Seems to work properly

[pdurbin]

@bjosel ok, thanks so much for testing. I'm glad there's no issue in the new UI.

[qqmyers]

I'm guessing it's this commit which removed replacing an empty list with null. 9baf2d5#diff-80df39df6cfebe2044116b34839cce6c0a72c1b58a0c7e245cd2f4056b91509fL515 . That causes and error because this statement then fails to return:

dataverse/src/main/java/edu/harvard/iq/dataverse/datasetutility/OptionalFileParams.java

Line 614 in b78060a

if (!hasFileDataTags()){

due to

dataverse/src/main/java/edu/harvard/iq/dataverse/datasetutility/OptionalFileParams.java

Lines 201 to 203 in b78060a

	public boolean hasFileDataTags() {
	return dataFileTags != null;
	}

checking for null and not empty() .

[pdurbin]

@qqmyers hmm. From #11439. That would mean the bug was introduced in Dataverse 6.8.

[kbatyuk]

Looks like this still exists in 6.9. We are getting this error after the update. Any ideas if this will be resolved in the near future?