Refactor to use Spek

Author: IvanShafran

app/build.gradle

@@ -3,6 +3,8 @@ apply plugin: 'com.android.application'
 apply plugin: 'kotlin-android'
 
 apply plugin: 'kotlin-android-extensions'
+// junit5 doesn't support android projects out of the box
+apply plugin: 'de.mannodermaus.android-junit5'
 
 android {
     compileSdkVersion 28
@@ -20,16 +22,31 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
         }
     }
+    testOptions {
+        junitPlatform {
+            filters {
+                engines {
+                    include 'spek2'
+                }
+            }
+        }
+    }
 }
 
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
-    implementation"org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
+    implementation"org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
     implementation 'com.android.support:appcompat-v7:28.0.0'
+
     testImplementation 'junit:junit:4.12'
     testImplementation "org.mockito:mockito-core:2.27.0"
     testImplementation 'com.github.IvanShafran:shared-preferences-mock:1.0'
     testImplementation "com.nhaarman.mockitokotlin2:mockito-kotlin:2.1.0"
+    // spek2
+    testImplementation "org.spekframework.spek2:spek-dsl-jvm:$spek_version"
+    testImplementation "org.spekframework.spek2:spek-runner-junit5:$spek_version"
+    testImplementation "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"
+
     androidTestImplementation 'com.android.support.test:runner:1.0.2'
     androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'
 }

app/src/test/java/com/github/ivanshafran/unit_tests_evolution/v5/ShowRateUsLogicTest.kt

@@ -0,0 +1,110 @@
+package com.github.ivanshafran.unit_tests_evolution.v5
+
+import com.github.ivanshafran.sharedpreferencesmock.SPMockBuilder
+import com.github.ivanshafran.unit_tests_evolution.BuyPreferencesImpl
+import com.github.ivanshafran.unit_tests_evolution.RateUsPreferencesImpl
+import com.github.ivanshafran.unit_tests_evolution.ShowRateUsLogic
+import com.github.ivanshafran.unit_tests_evolution.Time
+import com.nhaarman.mockitokotlin2.mock
+import com.nhaarman.mockitokotlin2.whenever
+import org.junit.Assert
+import org.spekframework.spek2.Spek
+import org.spekframework.spek2.style.specification.describe
+import java.util.*
+import java.util.concurrent.TimeUnit
+
+class ShowRateUsLogicTest : Spek({
+
+    val calendar = Calendar.getInstance()
+    calendar.set(2019, Calendar.JULY, 7)
+
+    val SOME_DAY_IN_MILLIS = calendar.timeInMillis
+    val LESS_THAN_TWO_MONTHS = TimeUnit.DAYS.toMillis(59)
+    val MORE_THAN_TWO_MONTHS = TimeUnit.DAYS.toMillis(61)
+
+    val mockedContext = SPMockBuilder().createContext()
+
+    val rateUsPreferences by memoized { RateUsPreferencesImpl(mockedContext) }
+    val buyPreferences by memoized { BuyPreferencesImpl(mockedContext) }
+    val time by memoized { mock<Time>() }
+    val showRateUsLogic by memoized {
+        ShowRateUsLogic(
+            rateUsPreferences,
+            buyPreferences,
+            time
+        )
+    }
+
+    fun prepareConditions(
+        buyClickedTimes: Int = 0,
+        isNeverShownAgainClicked: Boolean = false,
+        isRateNowClicked: Boolean = false,
+        lastShownTimeMillis: Long = 0,
+        currentTimeMillis: Long = System.currentTimeMillis()
+    ) {
+        repeat(buyClickedTimes) { buyPreferences.incrementBuyCount() }
+
+        if (isNeverShownAgainClicked) rateUsPreferences.setNeverShownAgainClicked()
+        if (isRateNowClicked) rateUsPreferences.setRateNowClickedClicked()
+        rateUsPreferences.setLastShownTimeMillis(lastShownTimeMillis)
+
+        whenever(time.getCurrentTimeMillis()).thenReturn(currentTimeMillis)
+    }
+
+    describe("show rate us logic") {
+
+        context("first conditions checks") {
+            context("buy clicked once") {
+                beforeEachTest {
+                    prepareConditions(buyClickedTimes = 1)
+                }
+
+                it("should not show 'rate us'") {
+                    Assert.assertFalse(showRateUsLogic.shouldShowRateUs())
+                }
+            }
+
+            context("buy clicked two times") {
+                beforeEachTest {
+                    prepareConditions(buyClickedTimes = 2)
+                }
+
+                it("should show 'rate us'") {
+                    Assert.assertTrue(showRateUsLogic.shouldShowRateUs())
+                }
+            }
+        }
+
+        context("'rate us' was shown already") {
+            context("user clicked 'show me later' on the dialog") {
+                context("less than two months passed and user clicks buy") {
+                    beforeEachTest {
+                        prepareConditions(
+                            buyClickedTimes = 3,
+                            lastShownTimeMillis = SOME_DAY_IN_MILLIS,
+                            currentTimeMillis = SOME_DAY_IN_MILLIS + MORE_THAN_TWO_MONTHS
+                        )
+                    }
+
+                    it("should show 'rate us' again") {
+                        Assert.assertTrue(showRateUsLogic.shouldShowRateUs())
+                    }
+                }
+
+                context("more than two months passed and user clicks buy") {
+                    beforeEachTest {
+                        prepareConditions(
+                            buyClickedTimes = 3,
+                            lastShownTimeMillis = SOME_DAY_IN_MILLIS,
+                            currentTimeMillis = SOME_DAY_IN_MILLIS + MORE_THAN_TWO_MONTHS
+                        )
+                    }
+
+                    it("should show 'rate us' again") {
+                        Assert.assertTrue(showRateUsLogic.shouldShowRateUs())
+                    }
+                }
+            }
+        }
+    }
+})

build.gradle

@@ -2,6 +2,10 @@
 
 buildscript {
     ext.kotlin_version = '1.3.31'
+    ext.spek_version = '2.0.6'
+    ext.android_junit5_version = '1.4.2.0'
+    ext.junit5_runner = '0.2.2'
+
     repositories {
         google()
         jcenter()
@@ -10,6 +14,7 @@ buildscript {
     dependencies {
         classpath 'com.android.tools.build:gradle:3.4.2'
         classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+        classpath "de.mannodermaus.gradle.plugins:android-junit5:$android_junit5_version"
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
     }