Refactoring code to satisfy some pylint messages

Author: roman-ku

reddit_utils/__init__.py

@@ -27,9 +27,9 @@ def create_app(test_config=None):
         # load the test config if passed in
         app.config.from_mapping(test_config)
 
-    LOGGER_CONFIG = os.path.join(app.root_path, 'files', 'logging_config.yaml')
+    logger_config = os.path.join(app.root_path, 'files', 'logging_config.yaml')
 
-    with open(LOGGER_CONFIG) as fid:
+    with open(logger_config) as fid:
 
         try:
             global_config = yaml.safe_load(fid)

reddit_utils/auth.py

@@ -22,7 +22,7 @@ def login():
         token['client_secret'] = request.form['clientsecret']
         token['username'] = request.form['username']
         token['password'] = request.form['password']
-        
+
         result = get_reddit_object(token)
 
         if result['status'] == 'error':

reddit_utils/features/list_subreddits.py

@@ -5,12 +5,11 @@
 from pprint import pprint as pp
 
 from flask import (
-    Blueprint, flash, g, redirect, render_template, request, url_for
+    Blueprint, flash, g, render_template, request
 )
 
 from ..auth import api_access_required
 from ..reddit import get_reddit_object
-from .search import perform_search, check_form
 
 bp = Blueprint('list_subreddits', __name__)
 
@@ -50,14 +49,10 @@ def get_subs(token, get_latest, sort_by, sort_reverse):
 
     if result['status'] == 'error':
         return result
-    else:
-        reddit = result['data']
 
+    reddit = result['data']
     results = []
 
-    print('fetching items: ')
-    print('-'*200)
-
     for subreddit in reddit.user.subreddits(limit=None):
 
         subreddit.id            # trigger loading
@@ -112,10 +107,7 @@ def check_form(form):
     else:
         options['sort_by'] = 'subscribers'
 
-    if 'sort_order' in form and form['sort_order'] == 'desc':
-        options['sort_reverse'] = True
-    else:
-        options['sort_reverse'] = False
+    options['sort_reverse'] = 'sort_order' in form and form['sort_order'] == 'desc'
 
     # if we are not getting the latest post, we can't sort by the time of the last post
     if not options['get_latest'] and form['sort_by'] == 'last_post':

reddit_utils/features/search.py

@@ -1,11 +1,9 @@
 
-import json
 import logging
 
 import pprint
 from pprint import pprint as pp
 
-import praw
 from praw.models import Submission
 from praw.models import Comment
 
@@ -21,8 +19,8 @@ def perform_search(search_options, token):
 
     if result['status'] == 'error':
         return result
-    else:
-        reddit = result['data']
+
+    reddit = result['data']
 
     results = user_saved(reddit, **search_options)
     results = list(results) if results else []
@@ -129,6 +127,8 @@ def query_in_str(queries, string):
         if query in string:
             return True
 
+    return False
+
 
 
 def item_in_subreddit(item, subreddits):

reddit_utils/features/search_saved.py

@@ -3,7 +3,7 @@
 import pprint
 
 from flask import (
-    Blueprint, flash, g, redirect, render_template, request, url_for
+    Blueprint, flash, g, render_template, request
 )
 
 from ..auth import api_access_required

reddit_utils/reddit.py

@@ -11,8 +11,8 @@
 def get_reddit_object(token):
 
     try:
-        
-        reddit = praw.Reddit(user_agent= 'Script that searches saved posts',
+
+        reddit = praw.Reddit(user_agent='reddit_utils web app by Roman Kuleshov',
                              client_id=token['client_id'],
                              client_secret=token['client_secret'],
                              username=token['username'],
@@ -29,4 +29,4 @@ def get_reddit_object(token):
         return {'status': 'error', 'data': 'Error: ResponseException: ' + str(err)}
 
     except Exception as err:
-        return {'status': 'error', 'data': 'Unexpected Error: ' + str(err)}
+        return {'status': 'error', 'data': 'Unexpected Error: ' + str(err)}

reddit_utils/util.py

@@ -9,10 +9,10 @@
 
 class MakeFileHandler(logging.FileHandler):
 
-	# https://stackoverflow.com/questions/20666764/python-logging-how-to-ensure-logfile-directory-is-created
-	# https://stackoverflow.com/questions/600268/mkdir-p-functionality-in-python/600612#600612
+    # https://stackoverflow.com/questions/20666764/python-logging-how-to-ensure-logfile-directory-is-created
+    # https://stackoverflow.com/questions/600268/mkdir-p-functionality-in-python/600612#600612
 
-    def __init__(self, filename, mode='a', encoding=None, delay=0):            
+    def __init__(self, filename, mode='a', encoding=None, delay=0):
         pathlib.Path(os.path.dirname(filename)).mkdir(parents=True, exist_ok=True)
         logging.FileHandler.__init__(self, filename, mode, encoding, delay)
 
@@ -25,15 +25,15 @@ def format_full_date(value):
 
 
 def format_timestamp(value, only_distance=False):
-    
+
     return arrow.get(value).humanize(only_distance=only_distance)
 
 
 
 def format_karma_score(karma):
 
-	if karma > 1000:
-		karma = karma / 1000
-		karma = str(int(karma)) + 'k'
+    if karma > 1000:
+        karma = karma / 1000
+        karma = str(int(karma)) + 'k'
 
-	return karma
+    return karma