Skip to content

Comments

Add integer function to EPSG and ESRI types#333

Merged
juliohm merged 1 commit intomainfrom
integer-code
Dec 23, 2025
Merged

Add integer function to EPSG and ESRI types#333
juliohm merged 1 commit intomainfrom
integer-code

Conversation

@juliohm
Copy link
Member

@juliohm juliohm commented Dec 23, 2025

Utility function to extract integer from code types.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.15%. Comparing base (525c1be) to head (95705c1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   92.14%   92.15%           
=======================================
  Files          40       40           
  Lines        1807     1809    +2     
=======================================
+ Hits         1665     1667    +2     
  Misses        142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a utility function integer to extract the integer value from EPSG and ESRI code types. This provides a convenient way to retrieve the numeric code from parameterized CRSCode types.

Key Changes

  • Introduced CoordRefSystems.integer function with implementations for both EPSG{Code} and ESRI{Code} types
  • Added comprehensive test coverage for the new functionality
  • Reorganized code structure by moving ESRI type definition to group related implementations together

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/codes.jl Added integer function declaration and implementations for EPSG and ESRI types; reorganized ESRI type definition for better code grouping
test/codes.jl New test file validating integer extraction from EPSG{4326} and ESRI{102100}
test/runtests.jl Added new codes.jl test file to the test suite

The implementation follows established patterns in the codebase, with proper documentation format and qualified naming convention (CoordRefSystems.integer). The changes are clean, well-tested, and maintain consistency with the existing API design.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@juliohm juliohm merged commit 7e163d5 into main Dec 23, 2025
18 checks passed
@juliohm juliohm deleted the integer-code branch December 23, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants