Update v1.55.0

Fixes #75

Author: Vinyzu

.github/workflows/patchright_workflow.yml

@@ -61,7 +61,7 @@ jobs:
       - name: Install Playwright-Python Package
         if: steps.version_check.outputs.proceed == 'true'
         run: |
-          git clone https://github.com/microsoft/playwright-python  --branch ${{ env.playwright_version }}
+          git clone https://github.com/microsoft/playwright-python --branch ${{ env.playwright_version }}
           cd playwright-python
           python -m pip install --upgrade pip
           pip install -r local-requirements.txt

patch_python_package.py

@@ -5,7 +5,7 @@
 import toml
 
 patchright_version = os.environ.get('playwright_version')
-patchright_version = "1.52.5"
+patchright_version = "1.55.0"
 
 def patch_file(file_path: str, patched_tree: ast.AST) -> None:
     with open(file_path, "w") as f:
@@ -288,11 +288,11 @@ async def route_handler(route: Route) -> None:
             try:
                 if route.request.resource_type == "document" and route.request.url.startswith("http"):
                     protocol = route.request.url.split(":")[0]
-                    await route.continue_(url=f"{protocol}://patchright-init-script-inject.internal/")
+                    await route.fallback(url=f"{protocol}://patchright-init-script-inject.internal/")
                 else:
-                    await route.continue_()
+                    await route.fallback()
             except:
-                await route.continue_()
+                await route.fallback()
 
     if not self.route_injecting:
         if self._connection._is_sync:
@@ -342,11 +342,11 @@ async def route_handler(route: Route) -> None:
             try:
                 if route.request.resource_type == "document" and route.request.url.startswith("http"):
                     protocol = route.request.url.split(":")[0]
-                    await route.continue_(url=f"{protocol}://patchright-init-script-inject.internal/")
+                    await route.fallback(url=f"{protocol}://patchright-init-script-inject.internal/")
                 else:
-                    await route.continue_()
+                    await route.fallback()
             except:
-                await route.continue_()
+                await route.fallback()
 
     if not self.route_injecting and not self.context.route_injecting:
         if self._connection._is_sync:
@@ -412,6 +412,15 @@ async def route_handler(route: Route) -> None:
 
     patch_file("playwright-python/playwright/_impl/_clock.py", clock_tree)
 
+# Patching playwright/_impl/_tracing.py
+with open("playwright-python/playwright/_impl/_tracing.py") as f:
+    tracing_source = f.read()
+    tracing_tree = ast.parse(tracing_source)
+
+    for node in ast.walk(tracing_tree):
+        if isinstance(node, ast.AsyncFunctionDef) and node.name == "start":
+            node.body.insert(0, ast.parse("await self._parent.install_inject_route()"))
+
 # Patching playwright/async_api/_generated.py
 with open("playwright-python/playwright/async_api/_generated.py") as f:
     async_generated_source = f.read()

utils/modify_tests.py

@@ -6,11 +6,6 @@
     # Console Domain Disabled
     'test_console.py',
 
-    # query_selector is deprecated
-    'test_queryselector.py',
-    'test_element_handle.py',
-    'test_element_handle_wait_for_element_state.py',
-
     # https://github.com/Kaliiiiiiiiii-Vinyzu/patchright/issues/31
     'test_route_web_socket.py'
 ]
@@ -52,14 +47,12 @@
     # Disable Popup Blocking
     "test_page_event_should_have_an_opener",
 
-    # query_selector is deprecated
-    "test_should_work_with_layout_selectors",
-    "test_should_dispatch_click_event_element_handle",
-    "test_should_dispatch_drag_and_drop_events_element_handle",
-
     # Minor Differences in Call Log. Deemed Unimportant
     "test_should_be_attached_fail_with_not",
     "test_add_script_tag_should_include_source_url_when_path_is_provided",
+    # / Black Formatting
+    "test_should_collect_sources",
+    "test_should_record_trace_with_source",
 
     # Server/Client Header Mismatch
     "test_should_report_request_headers_array",
@@ -69,15 +62,10 @@
 
 dont_isolate_evaluation_tests = [
     "test_timeout_waiting_for_stable_position",
-    "test_jshandle_evaluate_accept_object_handle_as_argument",
-    "test_jshandle_evaluate_accept_nested_handle",
-    "test_jshandle_evaluate_accept_nested_window_handle",
-    "test_jshandle_evaluate_accept_multiple_nested_handles",
-    "test_should_dispatch_drag_drop_events",
-    "test_should_dispatch_drag_and_drop_events_element_handle",
     "track_events",
-    "captureLastKeydown",
     "test_expose_function_should_work_on_frames_before_navigation",
+    "test_should_dispatch_drag_drop_events",
+    "test_should_dispatch_drag_and_drop_events_element_handle",
 ]
 
 # Reason for skipping tests_backup
@@ -131,10 +119,14 @@ def process_file(file_path):
                     test_name = current_node.name
 
             if test_name in dont_isolate_evaluation_tests:
-                # Don't add isolated_context=False to these tests
+            #    # Don't add isolated_context=False to these tests
                 continue
 
-            if node.func.attr in ("evaluate", "evaluate_handle", "evaluate_all") and isinstance(node.func.value, ast.Name) and node.func.value.id in ("page", "popup", "button", "new_page", "page1", "page2", "target", "page_1", "page_2", "frame"):
+            if (node.func.attr in ("evaluate", "evaluate_handle", "evaluate_all")
+                and isinstance(node.func.value, ast.Name)
+                and node.func.value.id in ("page", "popup", "button", "new_page", "page1", "page2", "target", "page_1", "page_2", "frame")
+                and not (node.func.value.id == "button" and "element_handle" in file_path)
+            ):
                 node.keywords.append(ast.keyword(arg='isolated_context', value=ast.Constant(value=False)))
 
     modified_source = ast.unparse(ast.fix_missing_locations(file_tree))
@@ -213,5 +205,21 @@ def main():
             if file.endswith('.py'):
                 process_file(file_path)
 
+            if file == "test_queryselector.py":
+                with open(file_path, 'r', encoding='utf-8') as f:
+                    content = f.read()
+
+                # Replace the full quoted strings with valid Python expressions (not strings)
+                content = content.replace(
+                    "assert await page.eval_on_selector_all('isolated=ignored', 'es => window.__answer !== undefined')",
+                    """await page.evaluate('() => window.__answer = document.querySelector("span")', isolated_context=True)\n    assert await page.eval_on_selector_all('isolated=ignored', 'es => window.__answer !== undefined')"""
+                ).replace(
+                    "assert page.eval_on_selector_all('isolated=ignored', 'es => window.__answer !== undefined')",
+                    """page.evaluate('() => window.__answer = document.querySelector("span")', isolated_context=True)\n    assert page.eval_on_selector_all('isolated=ignored', 'es => window.__answer !== undefined')"""
+                )
+
+                with open(file_path, 'w', encoding='utf-8') as f:
+                    f.write(content)
+
 if __name__ == '__main__':
     main()