Skip to content

Commit fa37ca3

Browse files
mattdawkinsclaude
andcommitted
Fix lint errors for CI: prefer-destructuring and no-restricted-syntax
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 397076b commit fa37ca3

File tree

3 files changed

+9
-13
lines changed

3 files changed

+9
-13
lines changed

client/dive-common/components/AnnotationVisibilityMenu.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,10 +271,10 @@ export default defineComponent({
271271
>
272272
<v-menu
273273
v-if="button.id === 'text'"
274+
:key="`${button.id}-view`"
274275
open-on-hover
275276
bottom
276277
offset-y
277-
:key="`${button.id}-view`"
278278
:close-on-content-click="false"
279279
>
280280
<template #activator="{ on, attrs }">

client/platform/desktop/backend/native/viame.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -54,22 +54,17 @@ async function filterCsvByFrameRange(
5454

5555
const content = await fs.readFile(csvPath, 'utf-8');
5656
const lines = content.split('\n');
57-
const filteredLines: string[] = [];
58-
59-
for (const line of lines) {
57+
const filteredLines = lines.filter((line) => {
6058
if (line.startsWith('#') || line.trim() === '') {
61-
filteredLines.push(line);
62-
// eslint-disable-next-line no-continue
63-
continue;
59+
return true;
6460
}
6561
const parts = line.split(',');
6662
if (parts.length >= 3) {
6763
const frame = parseInt(parts[2], 10);
68-
if (!Number.isNaN(frame) && frame >= startFrame && frame <= endFrame) {
69-
filteredLines.push(line);
70-
}
64+
return !Number.isNaN(frame) && frame >= startFrame && frame <= endFrame;
7165
}
72-
}
66+
return false;
67+
});
7368

7469
await fs.writeFile(filteredPath, filteredLines.join('\n'));
7570
return filteredPath;

client/platform/web-girder/api/rpc.service.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ function runPipeline(itemId: string, pipeline: Pipe, frameRange?: [number, numbe
1616
pipeline,
1717
};
1818
if (frameRange) {
19-
params.startFrame = frameRange[0];
20-
params.endFrame = frameRange[1];
19+
const [startFrame, endFrame] = frameRange;
20+
params.startFrame = startFrame;
21+
params.endFrame = endFrame;
2122
}
2223
return girderRest.post('dive_rpc/pipeline', null, { params });
2324
}

0 commit comments

Comments
 (0)