Skip to content

Commit 9a7ea36

Browse files
committed
STY: Refactor string formatting linter
1 parent 6fdc2a5 commit 9a7ea36

File tree

2 files changed

+36
-14
lines changed

2 files changed

+36
-14
lines changed

asltk/utils.py

Lines changed: 34 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,12 @@ def load_image(
138138
return sitk.GetArrayFromImage(img)
139139

140140

141-
def _make_bids_path(bids_root, subject, session=None, suffix='asl', extension='.nii.gz'):
142-
subj_dir = f"sub-{subject}"
143-
ses_dir = f"ses-{session}" if session else None
144-
modality_dir = "asl"
141+
def _make_bids_path(
142+
bids_root, subject, session=None, suffix='asl', extension='.nii.gz'
143+
):
144+
subj_dir = f'sub-{subject}'
145+
ses_dir = f'ses-{session}' if session else None
146+
modality_dir = 'asl'
145147

146148
if ses_dir:
147149
out_dir = os.path.join(bids_root, subj_dir, ses_dir, modality_dir)
@@ -150,15 +152,22 @@ def _make_bids_path(bids_root, subject, session=None, suffix='asl', extension='.
150152

151153
os.makedirs(out_dir, exist_ok=True)
152154

153-
filename = f"sub-{subject}"
155+
filename = f'sub-{subject}'
154156
if session:
155-
filename += f"_ses-{session}"
156-
filename += f"_{suffix}{extension}"
157+
filename += f'_ses-{session}'
158+
filename += f'_{suffix}{extension}'
157159

158160
return os.path.join(out_dir, filename)
159161

160162

161-
def save_image(img: np.ndarray, full_path: str = None, *, bids_root: str = None, subject: str = None, session: str = None):
163+
def save_image(
164+
img: np.ndarray,
165+
full_path: str = None,
166+
*,
167+
bids_root: str = None,
168+
subject: str = None,
169+
session: str = None,
170+
):
162171
"""Save image to a file path.
163172
164173
All the available image formats provided in the SimpleITK API can be
@@ -174,13 +183,22 @@ def save_image(img: np.ndarray, full_path: str = None, *, bids_root: str = None,
174183
full_path = _make_bids_path(bids_root, subject, session)
175184

176185
if not full_path:
177-
raise ValueError("Either full_path or bids_root + subject must be provided.")
186+
raise ValueError(
187+
'Either full_path or bids_root + subject must be provided.'
188+
)
178189

179190
sitk_img = sitk.GetImageFromArray(img)
180191
sitk.WriteImage(sitk_img, full_path)
181192

182193

183-
def save_asl_data(asldata, fullpath: str = None, *, bids_root: str = None, subject: str = None, session: str = None):
194+
def save_asl_data(
195+
asldata,
196+
fullpath: str = None,
197+
*,
198+
bids_root: str = None,
199+
subject: str = None,
200+
session: str = None,
201+
):
184202
"""
185203
Save ASL data to a pickle file.
186204
@@ -217,10 +235,14 @@ def save_asl_data(asldata, fullpath: str = None, *, bids_root: str = None, subje
217235
If the provided filename does not end with '.pkl'.
218236
"""
219237
if bids_root and subject:
220-
fullpath = _make_bids_path(bids_root, subject, session, suffix='asl', extension='.pkl')
238+
fullpath = _make_bids_path(
239+
bids_root, subject, session, suffix='asl', extension='.pkl'
240+
)
221241

222242
if not fullpath:
223-
raise ValueError("Either fullpath or bids_root + subject must be provided.")
243+
raise ValueError(
244+
'Either fullpath or bids_root + subject must be provided.'
245+
)
224246

225247
if not fullpath.endswith('.pkl'):
226248
raise ValueError('Filename must be a pickle file (.pkl)')

tests/test_utils.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,9 +283,10 @@ def test_collect_data_volumes_error_if_input_is_less_than_3D():
283283
collected_volumes, _ = utils.collect_data_volumes(data)
284284
assert 'data is a 3D volume or higher dimensions' in e.value.args[0]
285285

286+
286287
def test_load_image_from_bids_structure_returns_valid_array():
287288
bids_root = 'tests/files/bids-example/asl001'
288-
subject = "Sub103"
289+
subject = 'Sub103'
289290
session = None
290291
modality = 'asl'
291292
suffix = None # m0 is deleted, because it does not exist
@@ -299,4 +300,3 @@ def test_load_image_from_bids_structure_returns_valid_array():
299300
)
300301

301302
assert img is not None
302-

0 commit comments

Comments
 (0)