Please fix pack id for Forged in the Barrens

[swilkins1337]

It should be 553. This went the whole expansion cycle without being fixed, so I'm hoping this can be fixed when this is updated for the latest expansion. I'm honestly worried that had I waited until after this was updated for the new expansion, the issue would've gone ignored.

[TheMrKochan]

use this plugin https://github.com/sgkoishi/PackTracker

[swilkins1337]

use this plugin https://github.com/sgkoishi/PackTracker

Has the author abandoned this project? If you're taking over, maybe this page https://github.com/HearthSim/Hearthstone-Deck-Tracker/wiki/Available-Plugins should be updated to point to your version. With permission from MGK82 of course.

Does your version incorrectly reset the pity timer when a golden card is opened, or have you fixed that?

[sgkoishi]

use this plugin https://github.com/sgkoishi/PackTracker

Has the author abandoned this project? If you're taking over, maybe this page https://github.com/HearthSim/Hearthstone-Deck-Tracker/wiki/Available-Plugins should be updated to point to your version. With permission from MGK82 of course.

Does your version incorrectly reset the pity timer when a golden card is opened, or have you fixed that?

That's my fork of this plugin, since the author here is not quite active. I'm not sure if it is abandoned, but this plugin is licensed under MIT, which is granting permission to everyone to modify and distribute their version.

I'm not sure if a golden version should reset the pity timer or not, since I do not have that many packs to open and test.
Do you have any proof for that? Please note that it is far from enough to prove it with tens or hundreds or even thousands of packs.

From my experience, golden cards will (likely) reset the pity timer.

[swilkins1337]

use this plugin https://github.com/sgkoishi/PackTracker

Has the author abandoned this project? If you're taking over, maybe this page https://github.com/HearthSim/Hearthstone-Deck-Tracker/wiki/Available-Plugins should be updated to point to your version. With permission from MGK82 of course.
Does your version incorrectly reset the pity timer when a golden card is opened, or have you fixed that?

That's my fork of this plugin, since the author here is not quite active. I'm not sure if it is abandoned, but this plugin is licensed under MIT, which is granting permission to everyone to modify and distribute their version.

I'm not sure if a golden version should reset the pity timer or not, since I do not have that many packs to open and test.
Do you have any proof for that? Please note that it is far from enough to prove it with tens or hundreds or even thousands of packs.

From my experience, golden cards will (likely) reset the pity timer.

I didn't think you needed permission to fork this plugin, but I thought it would be a good idea to ask before changing that wiki page and taking over as the main version everybody downloads.

I can refer you to issue #35. I think it offers pretty good proof.

[sgkoishi]

I can refer you to issue #35. I think it offers pretty good proof.

From the link I only see pity timer for epics, golden common and golden rare. Golden epics and legds are missing due to lack of data; there's no way to tell if golden version reset regular epics and legds pity timer.

Golden epics and legds have their own pity timer and Golden epics and legds will reset the regular pity timer can exist at the same time, without conflicting.
For example, you got regular epic from 1st and 15th pack, and a golden epic from 9th pack. This means Golden epics and legds will reset the regular pity timer; I'm somehow sure I've experience something similar (even tho I didn't actually check my log so it can be wrong).

In order to show a golden card do reset regular pity timer, you need data to show that all (mostly, or a large amount) of the Epic-GoldenEpic-Epic patterns are in a sequence of up to 11 packs, and/or all Legend-GoldenLegend-Legend patterns in 41 packs. If any Epic-GoldenEpic-Epic exists in a more than 11 packs sequence (or legds-41 packs), it means that the golden card do reset regular pity timer.

Edit: Oops, I scroll to the end of the post and saw the analysis. It seems reasonable, but I have no idea how to make the new UI for golden version. I can add an option to switch if golden version resets or not (it seems not so intuitive for me if golden doesn't reset regular pity timer). Do you have any idea for this?

[swilkins1337]

I can refer you to issue #35. I think it offers pretty good proof.

From the link I only see pity timer for epics, golden common and golden rare. Golden epics and legds are missing due to lack of data; there's no way to tell if golden version reset regular epics and legds pity timer.

Golden epics and legds have their own pity timer and Golden epics and legds will reset the regular pity timer can exist at the same time, without conflicting.
For example, you got regular epic from 1st and 15th pack, and a golden epic from 9th pack. This means Golden epics and legds will reset the regular pity timer; I'm somehow sure I've experience something similar (even tho I didn't actually check my log so it can be wrong).

In order to show a golden card do reset regular pity timer, you need data to show that all (mostly, or a large amount) of the Epic-GoldenEpic-Epic patterns are in a sequence of up to 11 packs, and/or all Legend-GoldenLegend-Legend patterns in 41 packs. If any Epic-GoldenEpic-Epic exists in a more than 11 packs sequence (or legds-41 packs), it means that the golden card do reset regular pity timer.

Edit: Oops, I scroll to the end of the post and saw the analysis. It seems reasonable, but I have no idea how to make the new UI for golden version. I can add an option to switch if golden version resets or not (it seems not so intuitive for me if golden doesn't reset regular pity timer). Do you have any idea for this?

I was going to say it's in the second Reddit link, then ask if that sample size was too small. I guess a toggle switch in the plugin settings could work if you don't want to just change the behavior. With golden cards resetting it, it just means it would never reach 9 or 39. And if they don't reset it, and it does go over that many packs, then it's a good sign that golden cards do reset the pity timer. I'm assuming you weren't talking about tracking golden cards. If you were, I'd say don't bother.

While I'm here, why are there two entries for "Classic" and one for "Welcome Bundle"? The Welcome Bundle gave Classic packs anyway. The original version seems to hide packs from the menus that you've never opened, and I think the selection defaults to the last pack you opened. I'm not sure what you might've done to change that, but it's a lot more of a pain to find the pack I want to view in the menu.

[sgkoishi]

I was going to say it's in the second Reddit link, then ask if that sample size was too small. I guess a toggle switch in the plugin settings could work if you don't want to just change the behavior. With golden cards resetting it, it just means it would never reach 9 or 39. And if they don't reset it, and it does go over that many packs, then it's a good sign that golden cards do reset the pity timer. I'm assuming you weren't talking about tracking golden cards. If you were, I'd say don't bother.

I've added a switch for "Golden card reset regular pity timer or not" (I didn't have chance to open any golden epic or legds to test, so hopefully it works!)

While I'm here, why are there two entries for "Classic" and one for "Welcome Bundle"? The Welcome Bundle gave Classic packs anyway. The original version seems to hide packs from the menus that you've never opened, and I think the selection defaults to the last pack you opened. I'm not sure what you might've done to change that, but it's a lot more of a pain to find the pack I want to view in the menu.

I extract those pairs from the game data, I have no idea why some of them exist. I thought I should implement something to hide it, but I realize I've done that. Please uncheck the "Show Untracked" option to hide them.
The reason why they are shown is that a new feature allows you to see how many packs you've opened. It shows the total amount of packs while the game is running, no matter if you have use this plugin to track or not earlier; someone may want to show those unopeneduntracked packs.

[swilkins1337]

I've added a switch for "Golden card reset regular pity timer or not" (I didn't have chance to open any golden epic or legds to test, so hopefully it works!)

I think the label you gave that switch makes it kind of unintuitive as to what it does. Perhaps "Count Golden Cards" would be better. Because actually, it might be more accurate to say a golden card has no effect on the pity timer for regular cards.

I extract those pairs from the game data, I have no idea why some of them exist. I thought I should implement something to hide it, but I realize I've done that. Please uncheck the "Show Untracked" option to hide them.
The reason why they are shown is that a new feature allows you to see how many packs you've opened. It shows the total amount of packs while the game is running, no matter if you have use this plugin to track or not earlier; someone may want to show those unopeneduntracked packs.

Could there be some indication of which one is the real Classic? I also think the default menu selection should be the same whether "Show Untracked" is on or not. For example, since the last pack I opened was United in Stormwind, that's what comes up when I open PityTimers (why doesn't that have a space?) or Statistic when it's off, but the selection is blank when it's on, and I have to find the set I want, which is usually the one I last opened a pack from. So I think the set for the most recent pack in the history is a sensible default.

According to https://hearthstone.fandom.com/wiki/Card_pack#Types_of_card_packs Class, Golden and Year packs don't have pity timers. I don't know if you want to trust the wiki, especially since they don't cite anything, but I thought I'd bring it up.

[sgkoishi]

Could there be some indication of which one is the real Classic? I also think the default menu selection should be the same whether "Show Untracked" is on or not. For example, since the last pack I opened was United in Stormwind, that's what comes up when I open PityTimers (why doesn't that have a space?) or Statistic when it's off, but the selection is blank when it's on, and I have to find the set I want, which is usually the one I last opened a pack from. So I think the set for the most recent pack in the history is a sensible default.

Will fix, it's a minor update so no plan to create a new release tho.

According to https://hearthstone.fandom.com/wiki/Card_pack#Types_of_card_packs Class, Golden and Year packs don't have pity timers. I don't know if you want to trust the wiki, especially since they don't cite anything, but I thought I'd bring it up.

I'm pretty sure @Celestalon said no pity timer for Golden packs, but the context is about guaranteed legendary in first 10 packs and only Golden Classic exists at that time. And they have never admitted the 40 pack pity timer, tho recently they admitted that the chance of epics/legds varies as you open without getting them. I'm not sure if the 40 pack rule applies (the screenshots said "not following any rule" but they didn't admit the 40 pack rule exists), or if it applies to all golden packs or just golden classic (or just not golden classic).
For other Class and Year packs, I have no idea where this information comes from.
So, I would prefer to leave it as is for now.

[swilkins1337]

I'm pretty sure @Celestalon said no pity timer for Golden packs, but the context is about guaranteed legendary in first 10 packs and only Golden Classic exists at that time. And they have never admitted the 40 pack pity timer, tho recently they admitted that the chance of epics/legds varies as you open without getting them. I'm not sure if the 40 pack rule applies (the screenshots said "not following any rule" but they didn't admit the 40 pack rule exists), or if it applies to all golden packs or just golden classic (or just not golden classic).
For other Class and Year packs, I have no idea where this information comes from.
So, I would prefer to leave it as is for now.

I guess one could stockpile Year packs from the weekly Tavern Brawls, then see if you go more than 10 without an epic, but you can't buy those or Class packs except in special bundles, so you aren't as likely to hit those numbers. Dean Ayala responded to a Q&A question a few weeks ago and said they implement a probability curve for a guaranteed legendary after 40 packs.

[Volkai7]

Reiterating request for update.

In regards to someone not MGK82 saying "use {other} plugin", this is the only Pack Tracker linked at https://github.com/HearthSim/Hearthstone-Deck-Tracker/wiki/Available-Plugins and therefore the only Pack Tracker I trust to install on my device.

[swilkins1337]

Reiterating request for update.

In regards to someone not MGK82 saying "use {other} plugin", this is the only Pack Tracker linked at https://github.com/HearthSim/Hearthstone-Deck-Tracker/wiki/Available-Plugins and therefore the only Pack Tracker I trust to install on my device.

I installed his fork. It's fine. I don't think being listed on the wiki page is any guarantee of safety, and if you look at the edit history of that page, you'll see that the plugin authors added their plugins to the list. If you read the discussion you might've noticed that I suggested he upgrade the wiki to point to his fork if MGK82 is okay with that.

I think the probability of downloading malware from GitHub is pretty low, but you could also look through the change history since the repo was forked and see if anything looked suspicious.