OPTIMADE JSON Lines specification appendix#531
Conversation
Fix code block formatting Update optimade.rst Apply suggestions from code review Apply suggestions from code review Try to fix formatting again Fix formatting and add note about provider fields
6929f10 to
c5f1f53
Compare
96b0231 to
78e158c
Compare
Co-authored-by: Kristjan Eimre <eimrek@users.noreply.github.com>
Co-authored-by: Kristjan Eimre <eimrek@users.noreply.github.com>
rartino
left a comment
There was a problem hiding this comment.
Looks good; and as we said during the web meet, very important extension.
However, how are relationships encoded? Maybe it would be nice if the example included a structure that has a relationship to a reference so one can see explicitly how that is encoded?
Co-authored-by: Rickard Armiento <gitcommits@armiento.net>
I think "serving" is an entirely different thing; |
e9ff554 to
2f9e2d7
Compare
Co-authored-by: Kristjan Eimre <eimrek@users.noreply.github.com>
Co-authored-by: Kristjan Eimre <eimrek@users.noreply.github.com>
Co-authored-by: Kristjan Eimre <eimrek@users.noreply.github.com>
merkys
left a comment
There was a problem hiding this comment.
I have no objections for this to be merged. I have myself encountered a need to store database subsets in OPTIMADE format, and this format seems to be just what I need.
Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com> Co-authored-by: Andrius Merkys <andrius.merkys@gmail.com>
This PR begins the work on #471, by defining the conventions on top of JSON Lines for deserializing an entire OPTIMADE API into a file.