Update button not always enabled

[mebibou]

The "update" button is not always clickable, even after making some edits in the HTML template. I think the button could be always enabled anyways, as updating without changes would still work. I have this problem regularly and need to open the developer tools and remove the disabled attribute manually to fix it

[mebibou]

Actually just tried to duplicate a template, and same the "Create" button remained disabled

[MattRuddick]

Thanks @mebibou for raising this. Here are my findings and actions:

The "update" button is not always clickable, even after making some edits in the HTML template. I think the button could be always enabled anyways, as updating without changes would still work. I have this problem regularly and need to open the developer tools and remove the disabled attribute manually to fix it

This one I was struggling to replicate... I went to edit a template and entered a character into the 'Subject', 'Text' and 'Html' inputs and every time I found that the 'Update' button had the 'disabled' attribute removed as expected.

It's worth noting here that the app did previously have a problem with the 'Update' button only becoming active on 'change' of an input and thus the user needed to focus out of the input for the CTA to then become active. I have since changed the logic to listen for 'keyup' events on those inputs which made for a much better UX and the button becoming active straight away upon the user typing.

The fix for this went into version v1.5.4. Let me know if you're still having issues and I'll take another look.

Actually just tried to duplicate a template, and same the "Create" button remained disabled

I've just put in a fix for this one and will be releasing shortly. Now the 'Create' button is immediately active when duplicating a template.

[mebibou]

@MattRuddick I cloned the master branch of the repo when I tested it out 24 days ago, so after release 1.5.4.

I still think that, regardless of the bug, it might be a lot simpler to not set disabled on the button at all, and instead show that the template is required (*) and do nothing when its empty and the button is clicked.