Skip to content

chore: Delete dead lockdown code#3841

Merged
FrederikBolding merged 2 commits intomainfrom
fb/delete-dead-lockdown
Feb 4, 2026
Merged

chore: Delete dead lockdown code#3841
FrederikBolding merged 2 commits intomainfrom
fb/delete-dead-lockdown

Conversation

@FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 4, 2026

Remove dead lockdown code from when we were manually running lockdown. This is no longer the case as the execution environments use LavaMoat.


Note

Low Risk
Low risk: deletes a dead, unused helper and only affects code hygiene; remaining lockdown hardening continues to be handled via LavaMoat plus existing executeLockdownMore/executeLockdownEvents calls.

Overview
Removes the unused SES executeLockdown helper (src/common/lockdown/lockdown.ts), leaving lockdown initiation to LavaMoat and retaining only the extra hardening steps (executeLockdownMore and executeLockdownEvents) invoked by the execution environment entrypoints.

Updates coverage.json thresholds to reflect the small change in measured line/statement coverage.

Written by Cursor Bugbot for commit 31950ca. This will update automatically on new commits. Configure here.

@FrederikBolding FrederikBolding requested a review from a team as a code owner February 4, 2026 13:49
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (2887a53) to head (31950ca).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3841      +/-   ##
==========================================
+ Coverage   98.47%   98.59%   +0.11%     
==========================================
  Files         430      429       -1     
  Lines       12433    12417      -16     
  Branches     1929     1928       -1     
==========================================
- Hits        12243    12242       -1     
+ Misses        190      175      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Feb 4, 2026
Merged via the queue into main with commit ff56831 Feb 4, 2026
129 checks passed
@FrederikBolding FrederikBolding deleted the fb/delete-dead-lockdown branch February 4, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants