lint fix

Alessandro100 · Alessandro100 · commit 9d382f34a605 · 2026-02-03T11:46:56.000-05:00
diff --git a/src/app/App.tsx b/src/app/App.tsx
@@ -21,7 +21,7 @@ function App({ locale }: AppProps): React.ReactElement {
 
   // Determine basename for BrowserRouter based on locale
   // Non-default locales (e.g., 'fr') need their prefix as basename
-  const basename = locale && locale !== 'en' ? `/${locale}` : undefined;
+  const basename = locale != null && locale !== 'en' ? `/${locale}` : undefined;
 
   useEffect(() => {
     app.auth().onAuthStateChanged((user) => {
@@ -36,14 +36,14 @@ function App({ locale }: AppProps): React.ReactElement {
   }, [dispatch]);
 
   return (
-      <Suspense>
-        <LocalizationProvider dateAdapter={AdapterDayjs}>
-          {/* BrowserRouter will be deprecated in favor of Next AppRouter */}
-          <BrowserRouter basename={basename}>
-            <AppContainer>{isAppReady ? <AppRouter /> : null}</AppContainer>
-          </BrowserRouter>
-        </LocalizationProvider>
-      </Suspense>
+    <Suspense>
+      <LocalizationProvider dateAdapter={AdapterDayjs}>
+        {/* BrowserRouter will be deprecated in favor of Next AppRouter */}
+        <BrowserRouter basename={basename}>
+          <AppContainer>{isAppReady ? <AppRouter /> : null}</AppContainer>
+        </BrowserRouter>
+      </LocalizationProvider>
+    </Suspense>
   );
 }
 
diff --git a/src/app/[locale]/[...slug]/page.tsx b/src/app/[locale]/[...slug]/page.tsx
@@ -16,7 +16,7 @@ interface PageProps {
 
 export default function Page({ params }: PageProps): ReactNode {
   const { locale } = use(params);
-  
+
   // Pass locale to App so BrowserRouter can use correct basename
   return <App locale={locale} />;
 }
diff --git a/src/app/[locale]/about/page.tsx b/src/app/[locale]/about/page.tsx
@@ -1,11 +1,13 @@
 import { type ReactElement } from 'react';
 import { setRequestLocale } from 'next-intl/server';
-import { routing } from '../../../i18n/routing';
+import { type AVAILABLE_LOCALES, routing } from '../../../i18n/routing';
 import AboutPage from './components/AboutPage';
 
 export const dynamic = 'force-static';
 
-export function generateStaticParams() {
+export function generateStaticParams(): Array<{
+  locale: (typeof AVAILABLE_LOCALES)[number];
+}> {
   return routing.locales.map((locale) => ({ locale }));
 }
 
diff --git a/src/app/[locale]/layout.tsx b/src/app/[locale]/layout.tsx
@@ -11,11 +11,12 @@ import { Mulish, IBM_Plex_Mono } from 'next/font/google';
 import Footer from '../components/Footer';
 import Header from '../components/Header';
 import { Container } from '@mui/material';
-import { routing } from '../../i18n/routing';
+import { type AVAILABLE_LOCALES, routing } from '../../i18n/routing';
 
 export const metadata = {
   title: 'Mobility Database',
-  description: "Access GTFS, GTFS Realtime, GBFS transit data with over 4,000 feeds from 70+ countries on the web's leading transit data platform.",
+  description:
+    "Access GTFS, GTFS Realtime, GBFS transit data with over 4,000 feeds from 70+ countries on the web's leading transit data platform.",
   robots:
     process.env.VERCEL_ENV === 'production'
       ? 'index, follow'
@@ -46,13 +47,15 @@ const ibmPlexMono = IBM_Plex_Mono({
  * Generate static params for all locales.
  * This enables static generation for locale-prefixed routes.
  */
-export function generateStaticParams() {
+export function generateStaticParams(): Array<{
+  locale: (typeof AVAILABLE_LOCALES)[number];
+}> {
   return routing.locales.map((locale) => ({ locale }));
 }
 
 interface LocaleLayoutProps {
   children: React.ReactNode;
-  params: Promise<{ locale: string }>;
+  params: Promise<{ locale: (typeof AVAILABLE_LOCALES)[number] }>;
 }
 
 /**
@@ -81,8 +84,8 @@ export default async function LocaleLayout({
   return (
     <html lang={locale}>
       <head>
-        <link rel="preconnect" href="https://firebaseapp.com" />
-        <link rel="dns-prefetch" href="https://firebaseapp.com" />
+        <link rel='preconnect' href='https://firebaseapp.com' />
+        <link rel='dns-prefetch' href='https://firebaseapp.com' />
       </head>
       <body className={`${mulish.variable} ${ibmPlexMono.variable}`}>
         <ThemeRegistry>
@@ -110,4 +113,3 @@ export default async function LocaleLayout({
     </html>
   );
 }
-
diff --git a/src/app/[locale]/page.tsx b/src/app/[locale]/page.tsx
@@ -1,17 +1,19 @@
 import { type ReactElement } from 'react';
 import { setRequestLocale } from 'next-intl/server';
-import { routing } from '../../i18n/routing';
+import { type AVAILABLE_LOCALES, routing } from '../../i18n/routing';
 import HomePage from './components/HomePage';
 import { type Metadata } from 'next';
 
 export const dynamic = 'force-static';
 
-export function generateStaticParams() {
+export function generateStaticParams(): Array<{
+  locale: (typeof AVAILABLE_LOCALES)[number];
+}> {
   return routing.locales.map((locale) => ({ locale }));
 }
 
 interface PageProps {
-  params: Promise<{ locale: string }>;
+  params: Promise<{ locale: (typeof AVAILABLE_LOCALES)[number] }>;
 }
 
 export const metadata: Metadata = {
diff --git a/src/app/components/Context.tsx b/src/app/components/Context.tsx
@@ -1,11 +1,11 @@
 'use client';
 
-import React, { useEffect, useState } from 'react';
+import React, { useEffect } from 'react';
 import type ContextProviderProps from '../interface/ContextProviderProps';
 import { Provider } from 'react-redux';
 import { store } from '../store/store';
 import { PersistGate } from 'redux-persist/integration/react';
-import { persistStore, type Persistor } from 'redux-persist';
+import { persistStore } from 'redux-persist';
 import { useAppDispatch } from '../hooks';
 import { resetProfileErrors } from '../store/profile-reducer';
 
diff --git a/src/app/components/Header.tsx b/src/app/components/Header.tsx
@@ -50,35 +50,43 @@ import {
 } from '../store/profile-selectors';
 
 // Lazy load components not needed for initial render
-const LogoutConfirmModal = dynamic(() => import('./LogoutConfirmModal'), {
-  ssr: false,
-});
-const DrawerContent = dynamic(() => import('./HeaderMobileDrawer'), {
-  ssr: false,
-});
+const LogoutConfirmModal = dynamic(
+  async () => await import('./LogoutConfirmModal'),
+  {
+    ssr: false,
+  },
+);
+const DrawerContent = dynamic(
+  async () => await import('./HeaderMobileDrawer'),
+  {
+    ssr: false,
+  },
+);
 
 // Hook to safely access search params only on client
-function useClientSearchParams() {
-  const [searchParams, setSearchParams] = React.useState<URLSearchParams | null>(null);
-  
+function useClientSearchParams(): URLSearchParams | null {
+  const [searchParams, setSearchParams] =
+    React.useState<URLSearchParams | null>(null);
+
   React.useEffect(() => {
     if (typeof window !== 'undefined') {
       setSearchParams(new URLSearchParams(window.location.search));
     }
   }, []);
-  
+
   return searchParams;
 }
 
 export default function DrawerAppBar(): React.ReactElement {
   const clientSearchParams = useClientSearchParams();
   const hasTransitFeedsRedirectParam =
     clientSearchParams?.get('utm_source') === 'transitfeeds';
-    
+
   const theme = useTheme();
   const pathname = usePathname();
   const [mobileOpen, setMobileOpen] = React.useState(false);
-  const [hasTransitFeedsRedirect, setHasTransitFeedsRedirect] = React.useState(false);
+  const [hasTransitFeedsRedirect, setHasTransitFeedsRedirect] =
+    React.useState(false);
   const [openDialog, setOpenDialog] = React.useState(false);
   const [activeTab, setActiveTab] = React.useState('');
   const [navigationItems, setNavigationItems] = React.useState<
@@ -125,7 +133,8 @@ export default function DrawerAppBar(): React.ReactElement {
     handleMenuClose();
   };
 
-  const container = typeof window !== 'undefined' ? () => window.document.body : undefined;
+  const container =
+    typeof window !== 'undefined' ? () => window.document.body : undefined;
 
   const [anchorEl, setAnchorEl] = React.useState<null | HTMLElement>(null);
 
@@ -446,7 +455,7 @@ export default function DrawerAppBar(): React.ReactElement {
             severity='warning'
             onClose={() => {
               setHasTransitFeedsRedirect(false);
-              if (hasTransitFeedsRedirectParam && clientSearchParams) {
+              if (hasTransitFeedsRedirectParam && clientSearchParams != null) {
                 // Remove utm_source from URL
                 const newSearchParams = new URLSearchParams(clientSearchParams);
                 newSearchParams.delete('utm_source');
diff --git a/src/app/components/ThemeToggle.tsx b/src/app/components/ThemeToggle.tsx
@@ -8,11 +8,7 @@ const ThemeToggle = (): React.ReactElement => {
 
   return (
     <IconButton onClick={toggleTheme} color='inherit' aria-label='Theme Toggle'>
-      {mode === 'dark' ? (
-        <Brightness7Icon />
-      ) : (
-        <Brightness4Icon />
-      )}
+      {mode === 'dark' ? <Brightness7Icon /> : <Brightness4Icon />}
     </IconButton>
   );
 };
diff --git a/src/app/context/ThemeProvider.tsx b/src/app/context/ThemeProvider.tsx
@@ -11,24 +11,28 @@ import type ContextProviderProps from '../interface/ContextProviderProps';
 
 // TODO: Revisit theme for best SSR practices
 
-const ThemeContext = createContext({ 
+const ThemeContext = createContext({
   mode: ThemeModeEnum.light,
-  toggleTheme: () => {} 
+  toggleTheme: () => {},
 });
 
 export const ThemeProvider: React.FC<ContextProviderProps> = ({ children }) => {
   const prefersDarkMode = useMediaQuery('(prefers-color-scheme: dark)');
-  
+
   // Initialize with system preference for SSR, then check localStorage on client
   const [mode, setMode] = useState<ThemeModeEnum>(
-    prefersDarkMode ? ThemeModeEnum.dark : ThemeModeEnum.light
+    prefersDarkMode ? ThemeModeEnum.dark : ThemeModeEnum.light,
   );
 
   // Load theme from localStorage only on client side
   useEffect(() => {
     if (typeof window !== 'undefined') {
       const savedTheme = localStorage.getItem('theme');
-      if (savedTheme && Object.values(ThemeModeEnum).includes(savedTheme as ThemeModeEnum)) {
+      if (
+        savedTheme != null &&
+        savedTheme !== '' &&
+        Object.values(ThemeModeEnum).includes(savedTheme as ThemeModeEnum)
+      ) {
         setMode(savedTheme as ThemeModeEnum);
       }
     }
@@ -55,5 +59,5 @@ export const ThemeProvider: React.FC<ContextProviderProps> = ({ children }) => {
   );
 };
 
-export const useTheme = (): { mode: ThemeModeEnum, toggleTheme: () => void } =>
+export const useTheme = (): { mode: ThemeModeEnum; toggleTheme: () => void } =>
   useContext(ThemeContext);
diff --git a/src/i18n/navigation.ts b/src/i18n/navigation.ts
@@ -3,7 +3,7 @@ import { routing } from './routing';
 
 /**
  * Locale-aware navigation APIs.
- * 
+ *
  * Use these instead of Next.js navigation to automatically handle locale prefixes:
  * - Link: Locale-aware link component
  * - redirect: Server-side redirect with locale
diff --git a/src/i18n/request.ts b/src/i18n/request.ts
@@ -4,14 +4,14 @@ import { routing } from './routing';
 
 /**
  * next-intl request configuration.
- * 
+ *
  * This is called for every request and determines which locale/messages to use.
  * The locale comes from the [locale] route segment via the proxy.
  */
 export default getRequestConfig(async ({ requestLocale }) => {
   // Typically corresponds to the `[locale]` segment
   const requested = await requestLocale;
-  
+
   // Validate the locale, fall back to default if invalid
   const locale = hasLocale(routing.locales, requested)
     ? requested
diff --git a/src/i18n/routing.ts b/src/i18n/routing.ts
@@ -1,13 +1,15 @@
 import { defineRouting } from 'next-intl/routing';
 
+export const AVAILABLE_LOCALES = ['en', 'fr'] as const;
+
 /**
  * Centralized routing configuration for next-intl.
- * 
+ *
  * - English (en): Default locale, no prefix in URL (/)
  * - French (fr): Prefixed URL (/fr)
  */
 export const routing = defineRouting({
-  locales: ['en', 'fr'],
+  locales: AVAILABLE_LOCALES,
   defaultLocale: 'en',
   // Don't show /en prefix for default locale
   localePrefix: 'as-needed',
diff --git a/src/proxy.ts b/src/proxy.ts
@@ -14,12 +14,12 @@ import { routing } from './i18n/routing';
  * - If a supported locale already exists in the pathname, continue without redirect
  * - If no locale in pathname, internally rewrite to default locale path
  */
-export default function proxy(request: NextRequest) {
+export default function proxy(request: NextRequest): NextResponse<unknown> {
   const { pathname } = request.nextUrl;
 
   // Check if any supported locale already exists in the pathname
   const pathnameHasLocale = routing.locales.some(
-    (locale) => pathname.startsWith(`/${locale}/`) || pathname === `/${locale}`
+    (locale) => pathname.startsWith(`/${locale}/`) || pathname === `/${locale}`,
   );
 
   // If locale exists in path, let it through
@@ -42,4 +42,3 @@ export const config = {
   // - Static files with extensions (.ico, .png, etc.)
   matcher: ['/((?!api|_next|.*\\..*).*)'],
 };
-

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ interface PageProps {`
`16`	`16`
`17`	`17`	`export default function Page({ params }: PageProps): ReactNode {`
`18`	`18`	`const { locale } = use(params);`
`19`		`-`
	`19`	`+`
`20`	`20`	`// Pass locale to App so BrowserRouter can use correct basename`
`21`	`21`	`return <App locale={locale} />;`
`22`	`22`	`}`